Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: platform_tools/android/gyp/skia_android.gypi

Issue 235783003: Fix generation of Android SampleApp APK now that we default to using gyp's ninja generator. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'targets': [ 2 'targets': [
3 { 3 {
4 'target_name': 'CopySampleAppDeps', 4 'target_name': 'CopySampleAppDeps',
5 'type': 'none', 5 'type': 'none',
6 'dependencies': [ 6 'dependencies': [
7 'skia_lib.gyp:skia_lib', 7 'skia_lib.gyp:skia_lib',
8 'SampleApp.gyp:SampleApp', 8 'SampleApp.gyp:SampleApp',
9 ], 9 ],
10 'variables': { 10 'variables': {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 '../launcher/skia_launcher.cpp', 51 '../launcher/skia_launcher.cpp',
52 ], 52 ],
53 }, 53 },
54 { 54 {
55 'target_name': 'SampleApp_APK', 55 'target_name': 'SampleApp_APK',
56 'type': 'none', 56 'type': 'none',
57 'dependencies': [ 57 'dependencies': [
58 'CopySampleAppDeps', 58 'CopySampleAppDeps',
59 ], 59 ],
60 'variables': { 60 'variables': {
61 'ANDROID_SDK_ROOT': '<!(echo $ANDROID_SDK_ROOT)' 61 'ANDROID_SDK_ROOT': '<!(echo $ANDROID_SDK_ROOT)',
62 # the ninja generator treats PRODUCT_DIR as a relative path to the
63 # gyp directory but android ant build wants a path relative to the
64 # build.xml file so we do that adjustment here.
65 'ANDROID_OUT': '../../<(PRODUCT_DIR)/android'
62 }, 66 },
63 'actions': [ 67 'actions': [
64 { 68 {
65 'action_name': 'SkiaAndroid_apk', 69 'action_name': 'SkiaAndroid_apk',
66 'inputs': [ 70 'inputs': [
67 '<(android_base)/app/AndroidManifest.xml', 71 '<(android_base)/app/AndroidManifest.xml',
68 '<(android_base)/app/build.xml', 72 '<(android_base)/app/build.xml',
69 '<(android_base)/app/project.properties', 73 '<(android_base)/app/project.properties',
70 '<(android_base)/app/jni/com_skia_SkiaSampleRenderer.h', 74 '<(android_base)/app/jni/com_skia_SkiaSampleRenderer.h',
71 '<(android_base)/app/jni/com_skia_SkiaSampleRenderer.cpp', 75 '<(android_base)/app/jni/com_skia_SkiaSampleRenderer.cpp',
72 '<(android_base)/app/src/com/skia/SkiaSampleActivity.java', 76 '<(android_base)/app/src/com/skia/SkiaSampleActivity.java',
73 '<(android_base)/app/src/com/skia/SkiaSampleRenderer.java', 77 '<(android_base)/app/src/com/skia/SkiaSampleRenderer.java',
74 '<(android_base)/app/src/com/skia/SkiaSampleView.java', 78 '<(android_base)/app/src/com/skia/SkiaSampleView.java',
75 ], 79 ],
76 'outputs': [ 80 'outputs': [
77 '<(PRODUCT_DIR)/../android/bin/SkiaAndroid.apk', 81 '<(PRODUCT_DIR)/../android/bin/SkiaAndroid.apk',
78 ], 82 ],
79 'action': [ 83 'action': [
80 'ant', 84 'ant',
81 '-quiet', 85 '-quiet',
82 '-f', 86 '-f',
83 '<(android_base)/app/build.xml', 87 '<(android_base)/app/build.xml',
84 '-Dout.dir=<(PRODUCT_DIR)/android/bin', 88 '-Dout.dir=<(ANDROID_OUT)/bin',
85 '-Dgen.absolute.dir=<(PRODUCT_DIR)/android/gen', 89 '-Dgen.absolute.dir=<(ANDROID_OUT)/gen',
86 '-Dnative.libs.absolute.dir=<(PRODUCT_DIR)/android/libs', 90 '-Dnative.libs.absolute.dir=<(ANDROID_OUT)/libs',
87 '-Dout.final.file=<(PRODUCT_DIR)/android/bin/SkiaAndroid.apk', 91 '-Dout.final.file=<(ANDROID_OUT)/bin/SkiaAndroid.apk',
88 '-Dsdk.dir=<(ANDROID_SDK_ROOT)', 92 '-Dsdk.dir=<(ANDROID_SDK_ROOT)',
89 'debug', 93 'debug',
90 ], 94 ],
91 }, 95 },
92 ], 96 ],
93 }, 97 },
94 ], 98 ],
95 } 99 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698