Consolidate read-only exception throwing for SVG*TearOffs

Consolidate read-only exception throwing for SVG*TearOffs

Where possible, use the "standard" message for read-only objects from
ExceptionMessages. Move the setup of the ExceptionState with this
message to SVGPropertyTearOffBase and reuse. It also saves a small chunk
of code-space.

Also drop a bunch of vspace, reorder checks in
SVGPreserveAspectRatioTearOff to check for immutability first and do
less work on error in SVGMatrixTearOff.

Committed: https://crrev.com/2da30558858160bdb32812e3a1a1c172f0150e58
Cr-Commit-Position: refs/heads/master@{#419875}

[fs, 2016-09-19 22:04:21]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:04:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-19 22:09:02]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:09:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 23:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 23:27:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fs, 2016-09-20 10:58:00]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 10:58:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:19:05]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-20 12:31:07]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-09-20 20:22:33]

On 2016/09/20 at 12:31:08, fs wrote:
> 

LGTM

[fs, 2016-09-20 22:24:52]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-20 22:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 22:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:34:19]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-09-20 22:34:26]

Description was changed from

==========
Consolidate read-only exception throwing for SVG*TearOffs

Where possible, use the "standard" message for read-only objects from
ExceptionMessages. Move the setup of the ExceptionState with this
message to SVGPropertyTearOffBase and reuse. It also saves a small chunk
of code-space.

Also drop a bunch of vspace, reorder checks in
SVGPreserveAspectRatioTearOff to check for immutability first and do
less work on error in SVGMatrixTearOff.
==========

to

==========
Consolidate read-only exception throwing for SVG*TearOffs

Where possible, use the "standard" message for read-only objects from
ExceptionMessages. Move the setup of the ExceptionState with this
message to SVGPropertyTearOffBase and reuse. It also saves a small chunk
of code-space.

Also drop a bunch of vspace, reorder checks in
SVGPreserveAspectRatioTearOff to check for immutability first and do
less work on error in SVGMatrixTearOff.

Committed: https://crrev.com/2da30558858160bdb32812e3a1a1c172f0150e58
Cr-Commit-Position: refs/heads/master@{#419875}
==========

[commit-bot: I haz the power, 2016-09-20 22:34:27]

Patchset 3 (id:??) landed as
https://crrev.com/2da30558858160bdb32812e3a1a1c172f0150e58
Cr-Commit-Position: refs/heads/master@{#419875}