Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGRectTearOff.cpp

Issue 2357463002: Consolidate read-only exception throwing for SVG*TearOffs (Closed)
Patch Set: Baseline updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 12 matching lines...) Expand all
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "core/svg/SVGRectTearOff.h" 31 #include "core/svg/SVGRectTearOff.h"
32 32
33 #include "bindings/core/v8/ExceptionState.h"
34 #include "core/dom/ExceptionCode.h"
35 #include "core/svg/SVGElement.h" 33 #include "core/svg/SVGElement.h"
36 34
37 namespace blink { 35 namespace blink {
38 36
39 SVGRectTearOff::SVGRectTearOff(SVGRect* target, SVGElement* contextElement, Prop ertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName) 37 SVGRectTearOff::SVGRectTearOff(SVGRect* target, SVGElement* contextElement, Prop ertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName)
40 : SVGPropertyTearOff<SVGRect>(target, contextElement, propertyIsAnimVal, att ributeName) 38 : SVGPropertyTearOff<SVGRect>(target, contextElement, propertyIsAnimVal, att ributeName)
41 { 39 {
42 } 40 }
43 41
44 void SVGRectTearOff::setX(float f, ExceptionState& exceptionState) 42 void SVGRectTearOff::setX(float f, ExceptionState& exceptionState)
45 { 43 {
46 if (isImmutable()) { 44 if (isImmutable()) {
47 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only."); 45 throwReadOnly(exceptionState);
48 return; 46 return;
49 } 47 }
50
51 target()->setX(f); 48 target()->setX(f);
52 commitChange(); 49 commitChange();
53 } 50 }
54 51
55 void SVGRectTearOff::setY(float f, ExceptionState& exceptionState) 52 void SVGRectTearOff::setY(float f, ExceptionState& exceptionState)
56 { 53 {
57 if (isImmutable()) { 54 if (isImmutable()) {
58 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only."); 55 throwReadOnly(exceptionState);
59 return; 56 return;
60 } 57 }
61
62 target()->setY(f); 58 target()->setY(f);
63 commitChange(); 59 commitChange();
64 } 60 }
65 61
66 void SVGRectTearOff::setWidth(float f, ExceptionState& exceptionState) 62 void SVGRectTearOff::setWidth(float f, ExceptionState& exceptionState)
67 { 63 {
68 if (isImmutable()) { 64 if (isImmutable()) {
69 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only."); 65 throwReadOnly(exceptionState);
70 return; 66 return;
71 } 67 }
72
73 target()->setWidth(f); 68 target()->setWidth(f);
74 commitChange(); 69 commitChange();
75 } 70 }
76 71
77 void SVGRectTearOff::setHeight(float f, ExceptionState& exceptionState) 72 void SVGRectTearOff::setHeight(float f, ExceptionState& exceptionState)
78 { 73 {
79 if (isImmutable()) { 74 if (isImmutable()) {
80 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only."); 75 throwReadOnly(exceptionState);
81 return; 76 return;
82 } 77 }
83
84 target()->setHeight(f); 78 target()->setHeight(f);
85 commitChange(); 79 commitChange();
86 } 80 }
87 81
88 DEFINE_TRACE_WRAPPERS(SVGRectTearOff) 82 DEFINE_TRACE_WRAPPERS(SVGRectTearOff)
89 { 83 {
90 visitor->traceWrappers(contextElement()); 84 visitor->traceWrappers(contextElement());
91 } 85 }
92 86
93 } // namespace blink 87 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698