Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.cpp

Issue 2357463002: Consolidate read-only exception throwing for SVG*TearOffs (Closed)
Patch Set: Baseline updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.cpp
diff --git a/third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.cpp b/third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.cpp
index de0a6cb48cc18a9bdea36e1f3df9bc51e907996d..327c1900f984f014ed1ae0cd0af0639f7a9b420e 100644
--- a/third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.cpp
+++ b/third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.cpp
@@ -30,16 +30,24 @@
#include "core/svg/properties/SVGPropertyTearOff.h"
+#include "bindings/core/v8/ExceptionMessages.h"
+#include "bindings/core/v8/ExceptionState.h"
+#include "core/dom/ExceptionCode.h"
#include "core/svg/SVGElement.h"
namespace blink {
+void SVGPropertyTearOffBase::throwReadOnly(ExceptionState& exceptionState)
+{
+ exceptionState.throwDOMException(NoModificationAllowedError, ExceptionMessages::readOnly());
+}
+
void SVGPropertyTearOffBase::commitChange()
{
- ASSERT(!isImmutable());
+ DCHECK(!isImmutable());
if (!contextElement() || isAnimVal())
return;
- ASSERT(m_attributeName != QualifiedName::null());
+ DCHECK(m_attributeName != QualifiedName::null());
contextElement()->invalidateSVGAttributes();
contextElement()->svgAttributeBaseValChanged(m_attributeName);
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698