Issue 2357453002: Fix ENABLE_SWIFTSHADER flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2357453002: Fix ENABLE_SWIFTSHADER flag. (Closed)

Created:
4 years, 3 months ago by jbauman

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Fix ENABLE_SWIFTSHADER flag. Convert it to a build flag, as it never properly made the move from gyp. BUG=646660 Review-Url: https://codereview.chromium.org/2337243003 Cr-Commit-Position: refs/heads/master@{#418948} (cherry picked from commit cf75fd7cae6fc6eac96f98b89f39dffe81da4989) Committed: https://chromium.googlesource.com/chromium/src/+/9d59496fb778df70bcab29d3c39493a995a61fb5

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -4 lines)			Patch
M	chrome/browser/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/component_updater/swiftshader_component_installer.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/gl/BUILD.gn	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/gl/init/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gl/init/gl_initializer_win.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

jbauman

4 years, 3 months ago (2016-09-19 22:03:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9d59496fb778df70bcab29d3c39493a995a61fb5.