Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2357453002: Fix ENABLE_SWIFTSHADER flag. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix ENABLE_SWIFTSHADER flag. Convert it to a build flag, as it never properly made the move from gyp. BUG=646660 Review-Url: https://codereview.chromium.org/2337243003 Cr-Commit-Position: refs/heads/master@{#418948} (cherry picked from commit cf75fd7cae6fc6eac96f98b89f39dffe81da4989) Committed: https://chromium.googlesource.com/chromium/src/+/9d59496fb778df70bcab29d3c39493a995a61fb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/gl/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/gl/init/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/init/gl_initializer_win.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
4 years, 3 months ago (2016-09-19 22:03:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d59496fb778df70bcab29d3c39493a995a61fb5.

Powered by Google App Engine
This is Rietveld 408576698