Fix ENABLE_SWIFTSHADER flag.

Fix ENABLE_SWIFTSHADER flag.

Convert it to a build flag, as it never properly made the move from gyp.

BUG=646660
Committed: https://crrev.com/cf75fd7cae6fc6eac96f98b89f39dffe81da4989
Cr-Commit-Position: refs/heads/master@{#418948}

[jbauman, 2016-09-14 00:56:04]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 00:56:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:13:35]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbauman, 2016-09-14 01:26:20]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 01:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 02:48:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 02:48:36]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-09-14 20:24:56]

jbauman@chromium.org changed reviewers:
+ kbr@chromium.org, thakis@chromium.org

[jbauman, 2016-09-14 20:24:57]

kbr@: Please review.
thakis@: chrome/ OWNERS review.

[Ken Russell (switch to Gerrit), 2016-09-14 20:27:53]

+sugoi, capn

https://codereview.chromium.org/2337243003/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/2337243003/diff/20001/ui/gl/BUILD.gn#newcode12
ui/gl/BUILD.gn:12: enable_swiftshader = is_chrome_branded
It looks like this will take effect for all platforms rather than just Windows.
Is that correct and/or the intent?

[jbauman, 2016-09-14 20:30:39]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-09-14 20:32:30]

On 2016/09/14 20:27:53, Ken Russell wrote:
> +sugoi, capn
> 
> https://codereview.chromium.org/2337243003/diff/20001/ui/gl/BUILD.gn
> File ui/gl/BUILD.gn (right):
> 
> https://codereview.chromium.org/2337243003/diff/20001/ui/gl/BUILD.gn#newcode12
> ui/gl/BUILD.gn:12: enable_swiftshader = is_chrome_branded
> It looks like this will take effect for all platforms rather than just
Windows.
> Is that correct and/or the intent?

Actually, good point. I've limited it to windows-only now.

[Ken Russell (switch to Gerrit), 2016-09-14 20:50:21]

lgtm

[commit-bot: I haz the power, 2016-09-14 22:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:24:17]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-09-15 15:47:33]

lgtm with flag always set to false for now

https://codereview.chromium.org/2337243003/diff/40001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/2337243003/diff/40001/ui/gl/BUILD.gn#newcode12
ui/gl/BUILD.gn:12: enable_swiftshader = is_chrome_branded && is_win
could we start with this set to false, and then flip this in a separate cl?
as-is, the cl description sounds like this just adds a flag, not that it
actually changes behavior on windows

also, why do we enable this only in branded builds? we try to keep chromium and
chrome as similar as possible (but i suppose that's a question for the follow-up
with the actual switch)

[jbauman, 2016-09-15 19:20:16]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-09-15 19:20:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2337243003/#ps60001
(title: "disable by default")

[commit-bot: I haz the power, 2016-09-15 19:20:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:13:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 20:14:51]

Description was changed from

==========
Fix ENABLE_SWIFTSHADER flag.

Convert it to a build flag, as it never properly made the move from gyp.

BUG=646660
==========

to

==========
Fix ENABLE_SWIFTSHADER flag.

Convert it to a build flag, as it never properly made the move from gyp.

BUG=646660

Committed: https://crrev.com/cf75fd7cae6fc6eac96f98b89f39dffe81da4989
Cr-Commit-Position: refs/heads/master@{#418948}
==========

[commit-bot: I haz the power, 2016-09-15 20:14:52]

Patchset 4 (id:??) landed as
https://crrev.com/cf75fd7cae6fc6eac96f98b89f39dffe81da4989
Cr-Commit-Position: refs/heads/master@{#418948}

[sugoi1, 2016-09-16 15:44:04]

On 2016/09/15 20:14:52, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/cf75fd7cae6fc6eac96f98b89f39dffe81da4989
> Cr-Commit-Position: refs/heads/master@{#418948}

Hi Jon, does this need to be merged back into M53? (Does this mean SwiftShader
is not usable by users in M53?)