Issue 23570006: Refactoring: Add convenience method toPluginContainerImpl.

Issue 23570006: Refactoring: Add convenience method toPluginContainerImpl. (Closed)

Created:
7 years, 3 months ago by r.kasibhatla

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactoring: Add convenience method toPluginContainerImpl. Add easy convenience method toPluginContainerImpl() and use it. BUG=NONE TEST=None. No functionality change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157186

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rework with comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -11 lines)			Patch
M	Source/web/ChromeClientImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/ContextMenuClientImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/web/WebHelperPluginImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebNode.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebPluginContainerImpl.h	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download
M	Source/web/WebPluginDocument.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebPluginScrollbarImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/23570006/diff/1/Source/web/WebPluginContainerImpl.h File Source/web/WebPluginContainerImpl.h (right): https://codereview.chromium.org/23570006/diff/1/Source/web/WebPluginContainerImpl.h#newcode205 Source/web/WebPluginContainerImpl.h:205: // as many childs will be of type Widget. ...

7 years, 3 months ago (2013-09-03 12:59:33 UTC) #2

r.kasibhatla

On 2013/09/03 12:59:33, tkent wrote: > https://codereview.chromium.org/23570006/diff/1/Source/web/WebPluginContainerImpl.h > File Source/web/WebPluginContainerImpl.h (right): > > https://codereview.chromium.org/23570006/diff/1/Source/web/WebPluginContainerImpl.h#newcode205 > ...

7 years, 3 months ago (2013-09-03 14:32:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/23570006/6001

7 years, 3 months ago (2013-09-04 00:13:49 UTC) #5

Message was sent while issue was closed.

Change committed as 157186

Expand Messages | Collapse Messages