Source/web/ChromeClientImpl.cpp - Issue 23570006: Refactoring: Add convenience method toPluginContainerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 23570006: Refactoring: Add convenience method toPluginContainerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rework with comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index ac4d65aa7aaeb3b359746d3cbe096126fbbcc726..b248be293e416836aa62e0ffe8d0ad303f0151ce 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -586,7 +586,7 @@ void ChromeClientImpl::mouseDidMoveOverElement(

if (object && object->isWidget()) {

Widget* widget = toRenderWidget(object)->widget();

if (widget && widget->isPluginContainer()) {

- WebPluginContainerImpl* plugin = static_cast<WebPluginContainerImpl*>(widget);

+ WebPluginContainerImpl* plugin = toPluginContainerImpl(widget);

url = plugin->plugin()->linkAtPosition(result.roundedPointInInnerNodeFrame());

}

« no previous file with comments | « no previous file | Source/web/ContextMenuClientImpl.cpp » ('j') | no next file with comments »