Source/web/WebHelperPluginImpl.cpp - Issue 23570006: Refactoring: Add convenience method toPluginContainerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebHelperPluginImpl.cpp

Issue 23570006: Refactoring: Add convenience method toPluginContainerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rework with comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebHelperPluginImpl.cpp

diff --git a/Source/web/WebHelperPluginImpl.cpp b/Source/web/WebHelperPluginImpl.cpp

index d4c487a1bc9ed42fdd307d5ba3bb72d34e3d5563..8c8197482ffa061298f97bfc5122111cfde9dcba 100644

--- a/Source/web/WebHelperPluginImpl.cpp

+++ b/Source/web/WebHelperPluginImpl.cpp

@@ -166,7 +166,7 @@ WebPlugin* WebHelperPluginImpl::getPlugin()

WebCore::Widget* widget = toHTMLPlugInElement(node)->pluginWidget();

if (!widget)

return 0;

- WebPlugin* plugin = static_cast<WebPluginContainerImpl*>(widget)->plugin();

+ WebPlugin* plugin = toPluginContainerImpl(widget)->plugin();

ASSERT(plugin);

// If the plugin is a placeholder, it is not useful to the caller, and it

// could be replaced at any time. Therefore, do not return it.

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebNode.cpp » ('j') | no next file with comments »