Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2356703003: Revert of [d8] Fix the shared-library build (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
Michael Hablich, Hannes Payer (out of office), rmcilroy, ulan, v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [d8] Fix the shared-library build (patchset #12 id:20002 of https://codereview.chromium.org/2342563002/ ) Reason for revert: Unblocking roll Original issue's description: > [d8] Fix the shared-library build > > This commit ensures that the d8 shared library build uses the same logic as > the standard static build by exporting relevant functions and classes. > > BUG=chromium:646337 > > Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65 > Cr-Commit-Position: refs/heads/master@{#39503} TBR=jochen@chromium.org,vogelheim@chromium.org,bmeurer@chromium.org,titzer@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:646337 Committed: https://crrev.com/298ee9cde1577f2b24969d09032b6fb97e141e5a Cr-Commit-Position: refs/heads/master@{#39526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -98 lines) Patch
M BUILD.gn View 4 chunks +11 lines, -3 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/basic-block-profiler.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/d8.h View 12 chunks +22 lines, -0 lines 0 comments Download
M src/d8.cc View 43 chunks +116 lines, -9 lines 0 comments Download
M src/d8.gyp View 2 chunks +12 lines, -8 lines 0 comments Download
M src/factory.h View 3 chunks +11 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -9 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/spaces.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/inspector/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ostreams.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/snapshot/natives.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils.h View 4 chunks +4 lines, -7 lines 0 comments Download
M src/v8.gyp View 5 chunks +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-js.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [d8] Fix the shared-library build
4 years, 3 months ago (2016-09-20 07:12:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356703003/1
4 years, 3 months ago (2016-09-20 07:12:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 07:12:44 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 07:13:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/298ee9cde1577f2b24969d09032b6fb97e141e5a
Cr-Commit-Position: refs/heads/master@{#39526}

Powered by Google App Engine
This is Rietveld 408576698