Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: BUILD.gn

Issue 2356703003: Revert of [d8] Fix the shared-library build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index d929480005027437f325f2f852c1f65c62e5bee9..1d02296654aab8a89c0e89bbabd1e94befdd950e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -115,7 +115,10 @@
include_dirs = [ "." ]
if (is_component_build) {
- defines = [ "BUILDING_V8_SHARED" ]
+ defines = [
+ "V8_SHARED",
+ "BUILDING_V8_SHARED",
+ ]
}
}
@@ -139,7 +142,10 @@
# itself.
config("external_config") {
if (is_component_build) {
- defines = [ "USING_V8_SHARED" ]
+ defines = [
+ "V8_SHARED",
+ "USING_V8_SHARED",
+ ]
}
include_dirs = [ "include" ]
if (v8_enable_inspector_override) {
@@ -2371,7 +2377,6 @@
v8_executable("d8") {
sources = [
- "$target_gen_dir/d8-js.cc",
"src/d8.cc",
"src/d8.h",
]
@@ -2399,6 +2404,9 @@
sources += [ "src/d8-windows.cc" ]
}
+ if (!is_component_build) {
+ sources += [ "$target_gen_dir/d8-js.cc" ]
+ }
if (v8_enable_i18n_support) {
deps += [ "//third_party/icu" ]
}
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698