Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/snapshot/natives.h

Issue 2356703003: Revert of [d8] Fix the shared-library build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ostreams.h ('k') | src/utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/natives.h
diff --git a/src/snapshot/natives.h b/src/snapshot/natives.h
index a9dc306a3d45b1a5fd0f43ab7e4bfa3d9610ea4f..e44751537fab49b51d84507b3906279867205f8f 100644
--- a/src/snapshot/natives.h
+++ b/src/snapshot/natives.h
@@ -22,15 +22,8 @@
TEST
};
-// Extra handling for V8_EXPORT_PRIVATE in combination with USING_V8_SHARED
-// since definition of methods of classes marked as dllimport is not allowed.
template <NativeType type>
-#ifdef USING_V8_SHARED
class NativesCollection {
-#else
-class V8_EXPORT_PRIVATE NativesCollection {
-#endif // USING_V8_SHARED
-
public:
// The following methods are implemented in js2c-generated code:
« no previous file with comments | « src/ostreams.h ('k') | src/utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698