components/offline_pages/background/request_queue_in_memory_store.h - Issue 2356433004: [Offline pages] Extracting AddRequest method in RequestQueueStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.h

Issue 2356433004: [Offline pages] Extracting AddRequest method in RequestQueueStore (Closed)

Patch Set: Updating the callback for AddRequest. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_queue.cc ('k') | components/offline_pages/background/request_queue_in_memory_store.cc » ('j') | components/offline_pages/background/request_queue_store.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_in_memory_store.h

diff --git a/components/offline_pages/background/request_queue_in_memory_store.h b/components/offline_pages/background/request_queue_in_memory_store.h

index 22bae128f61efada534e1f8493b286ae01ee7f74..d13e4dd80f148a289bf83819a1b7f471564ed433 100644

--- a/components/offline_pages/background/request_queue_in_memory_store.h

+++ b/components/offline_pages/background/request_queue_in_memory_store.h

@@ -23,6 +23,8 @@ class RequestQueueInMemoryStore : public RequestQueueStore {

// RequestQueueStore implementaiton.

void GetRequests(const GetRequestsCallback& callback) override;

+ void AddRequest(const SavePageRequest& offline_page,

Pete Williamson 2016/09/21 00:00:07 So are you renaming AddOrUpdateRequest to UpdateRe

fgorski 2016/09/21 05:07:50 Correct.

+ const AddCallback& callback) override;

void AddOrUpdateRequest(const SavePageRequest& request,

const UpdateCallback& callback) override;