Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: components/offline_pages/background/request_queue.cc

Issue 2356433004: [Offline pages] Extracting AddRequest method in RequestQueueStore (Closed)
Patch Set: Updating the callback for AddRequest. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.cc
diff --git a/components/offline_pages/background/request_queue.cc b/components/offline_pages/background/request_queue.cc
index f0375d9b6b573b3af6ebee74f71f2a0e22c255e0..d6035324afc558544ac8f4a679f64613a24f4602 100644
--- a/components/offline_pages/background/request_queue.cc
+++ b/components/offline_pages/background/request_queue.cc
@@ -30,11 +30,22 @@ void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback,
// Completes the add request call.
void AddRequestDone(const RequestQueue::AddRequestCallback& callback,
const SavePageRequest& request,
- RequestQueueStore::UpdateStatus status) {
- RequestQueue::AddRequestResult result =
- (status == RequestQueueStore::UpdateStatus::UPDATED)
- ? RequestQueue::AddRequestResult::SUCCESS
- : RequestQueue::AddRequestResult::STORE_FAILURE;
+ ItemActionStatus status) {
+ RequestQueue::AddRequestResult result;
+ switch (status) {
+ case ItemActionStatus::SUCCESS:
+ result = RequestQueue::AddRequestResult::SUCCESS;
+ break;
+ case ItemActionStatus::ALREADY_EXISTS:
+ result = RequestQueue::AddRequestResult::ALREADY_EXISTS;
+ break;
+ case ItemActionStatus::STORE_ERROR:
+ result = RequestQueue::AddRequestResult::STORE_FAILURE;
+ break;
+ case ItemActionStatus::NOT_FOUND:
+ default:
+ NOTREACHED();
+ }
callback.Run(result, request);
}
@@ -80,8 +91,7 @@ void RequestQueue::AddRequest(const SavePageRequest& request,
const AddRequestCallback& callback) {
// TODO(fgorski): check that request makes sense.
// TODO(fgorski): check that request does not violate policy.
- store_->AddOrUpdateRequest(request,
- base::Bind(&AddRequestDone, callback, request));
+ store_->AddRequest(request, base::Bind(&AddRequestDone, callback, request));
}
void RequestQueue::UpdateRequest(const SavePageRequest& update_request,

Powered by Google App Engine
This is Rietveld 408576698