[Offline pages] Extracting AddRequest method in RequestQueueStore

components/offline_pages/background/request_queue_store.h

Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index f430b1036478233c0dce28fb728469ad0cf9936f..8ab21288e0d8d1488938115d7aba45105e3ed035 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -11,7 +11,7 @@
 #include "base/callback.h"
 #include "components/offline_pages/background/request_queue.h"
 #include "components/offline_pages/background/save_page_request.h"
-#include "components/offline_pages/offline_page_item.h"
+#include "components/offline_pages/offline_page_types.h"
 
 namespace offline_pages {
 
@@ -28,6 +28,7 @@ class RequestQueueStore {
       bool /* success */,
       std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
       GetRequestsCallback;
+  typedef base::Callback<void(ItemActionStatus)> AddCallback;
   typedef base::Callback<void(UpdateStatus)> UpdateCallback;

[Pete Williamson, 2016/09/21 00:00:07]

Does it make sense to use the same Status type for both add and Update since
they are similar?

[fgorski, 2016/09/21 05:07:50]

Yes, and it will use the bulk object and deliver status in a ID -> status
mapping... in tomorrow's patch.

   typedef base::Callback<void(
       const RequestQueue::UpdateMultipleRequestResults& /* statuses*/,
@@ -44,6 +45,11 @@ class RequestQueueStore {
   // Gets all of the requests from the store.
   virtual void GetRequests(const GetRequestsCallback& callback) = 0;
 
+  // Asynchronously adds request in store. Fails if request with the same
+  // offline ID already exists.
+  virtual void AddRequest(const SavePageRequest& offline_page,
+                          const AddCallback& callback) = 0;
+
   // Asynchronously adds or updates request in store.
   // Result of the update is passed in the callback.
   virtual void AddOrUpdateRequest(const SavePageRequest& request,