Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/test/data/webui/password_manager_internals_browsertest.js

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: innerHTML -> innerText Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/password_manager_internals_browsertest.js
diff --git a/chrome/test/data/webui/password_manager_internals_browsertest.js b/chrome/test/data/webui/password_manager_internals_browsertest.js
index 65aad3a2d27a9076258485e99cd9d8b17716f19f..dd3429cf4cb6b128481c8d8a8da27e342ac1a0b8 100644
--- a/chrome/test/data/webui/password_manager_internals_browsertest.js
+++ b/chrome/test/data/webui/password_manager_internals_browsertest.js
@@ -6,6 +6,9 @@ function testLogText() {
var divLogs = document.getElementById('log-entries');
assertNotEquals(null, divLogs, "The <div> with logs not found.");
assertNotEquals(null,
- divLogs.innerHTML.match(/text test text/),
+ divLogs.innerHTML.match(/text for testing/),
"The logged text not found.");
+ assertEquals(null,
+ divLogs.innerHTML.match(/<script>/),
+ "The logged text was not escaped.");
}

Powered by Google App Engine
This is Rietveld 408576698