Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: innerHTML -> innerText Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_messages.h
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h
index 387a4355896f2f9c5ca2ed427ce846fa3c535c05..265c5bc8e5182883a2dee9d701d0a9df414c2c6a 100644
--- a/components/autofill/content/common/autofill_messages.h
+++ b/components/autofill/content/common/autofill_messages.h
@@ -17,6 +17,7 @@
#include "components/autofill/core/common/forms_seen_state.h"
#include "components/autofill/core/common/password_form.h"
#include "components/autofill/core/common/password_form_fill_data.h"
+#include "components/autofill/core/common/save_password_progress_logger.h"
#include "components/autofill/core/common/web_element_descriptor.h"
#include "content/public/common/common_param_traits.h"
#include "content/public/common/common_param_traits_macros.h"
@@ -92,6 +93,23 @@ IPC_STRUCT_TRAITS_BEGIN(autofill::PasswordAndRealm)
IPC_STRUCT_TRAITS_END()
IPC_ENUM_TRAITS_MAX_VALUE(
+ autofill::SavePasswordProgressLogger::StructuredLog::LogType,
+ autofill::SavePasswordProgressLogger::StructuredLog::LogType::LOG_TYPE_MAX)
+
+IPC_ENUM_TRAITS_MAX_VALUE(autofill::SavePasswordProgressLogger::StringID,
+ autofill::SavePasswordProgressLogger::STRING_MAX)
+
+IPC_STRUCT_TRAITS_BEGIN(autofill::SavePasswordProgressLogger::StructuredLog)
+ IPC_STRUCT_TRAITS_MEMBER(log_type)
+ IPC_STRUCT_TRAITS_MEMBER(label)
+ IPC_STRUCT_TRAITS_MEMBER(url)
+ IPC_STRUCT_TRAITS_MEMBER(message)
+ IPC_STRUCT_TRAITS_MEMBER(number)
+ IPC_STRUCT_TRAITS_MEMBER(truth_value)
+ IPC_STRUCT_TRAITS_MEMBER(element_id)
+IPC_STRUCT_TRAITS_END()
+
+IPC_ENUM_TRAITS_MAX_VALUE(
blink::WebFormElement::AutocompleteResult,
blink::WebFormElement::AutocompleteResultErrorInvalid)
@@ -188,9 +206,11 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsRendered,
IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,
autofill::PasswordForm /* form */)
-// Notification that logs during saving the password have been gathered.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_RecordSavePasswordProgress,
- std::string /* log */)
+// Sends the collected logs to browser for sanitization and displaying to the
+// user.
+IPC_MESSAGE_ROUTED1(
+ AutofillHostMsg_RecordSavePasswordProgress,
+ std::vector<autofill::SavePasswordProgressLogger::StructuredLog> /* logs */)
// Notification that a form has been submitted. The user hit the button.
IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormSubmitted,

Powered by Google App Engine
This is Rietveld 408576698