chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc - Issue 235623002: Password manager internals page: Improve security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: innerHTML -> innerText Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client.h ('K') | « chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc ('k') | chrome/test/data/webui/password_manager_internals_browsertest.js » ('j') | components/autofill/core/common/save_password_progress_logger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

index bc1aadab79565dc49f7b26a99b6fc77dafe4a0ba..532adf45d1e4d1c557013a1c573fb3ff85d1dec5 100644

--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

@@ -62,6 +62,6 @@ PasswordManagerInternalsWebUIBrowserTest::GetWebContents() {

IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,

LogSavePasswordProgress) {

- controller()->LogSavePasswordProgress("text test text");

+ controller()->LogSavePasswordProgress("<script> text for testing");

ASSERT_TRUE(RunJavascriptTest("testLogText"));

}