chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc - Issue 235623002: Password manager internals page: Improve security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: innerHTML -> innerText Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client.h ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc » ('j') | components/autofill/core/common/save_password_progress_logger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

index 212bfd0fd681d395f100ab386ae7a7090212ada9..81baa1daf50569d7c8e2020b61752562933a694e 100644

--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

@@ -22,6 +22,7 @@

#include "content/public/browser/web_ui.h"

#include "content/public/browser/web_ui_data_source.h"

#include "grit/password_manager_internals_resources.h"

+#include "net/base/escape.h"

using content::BrowserContext;

using content::WebContents;

@@ -66,7 +67,7 @@ PasswordManagerInternalsUI::~PasswordManagerInternalsUI() {

void PasswordManagerInternalsUI::LogSavePasswordProgress(

const std::string& text) {

- base::StringValue text_string_value(text);

+ base::StringValue text_string_value(net::EscapeForHTML(text));

web_ui()->CallJavascriptFunction("addSavePasswordProgressLog",

text_string_value);

}