Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2355743003: MIPS: [turbofan] Optimize sign-extension patterns like Sar(Shl(x, a), b)). (Closed)

Created:
4 years, 3 months ago by Marija Antic
Modified:
4 years, 3 months ago
Reviewers:
ivica.bogosavljevic, balazs.kilvady, miran.karic, ilija.pavlovic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Optimize sign-extension patterns like Sar(Shl(x, a), b)). Port of https://crrev.com/14a5c18cc35b2c55b37de3bd0ad27941cf21cb68 BUG= Committed: https://crrev.com/3d97b804c9aca1b93ede06120170abf26381c016 Cr-Commit-Position: refs/heads/master@{#39582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -3 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
Marija Antic
PTAL.
4 years, 3 months ago (2016-09-20 08:10:37 UTC) #4
ivica.bogosavljevic
On 2016/09/20 08:10:37, Marija Antic wrote: > PTAL. lgtm
4 years, 3 months ago (2016-09-21 07:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355743003/1
4 years, 3 months ago (2016-09-21 08:06:07 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-21 08:06:09 UTC) #13
balazs.kilvady
lgtm
4 years, 3 months ago (2016-09-21 08:50:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355743003/1
4 years, 3 months ago (2016-09-21 09:20:16 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 09:26:35 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 09:27:22 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d97b804c9aca1b93ede06120170abf26381c016
Cr-Commit-Position: refs/heads/master@{#39582}

Powered by Google App Engine
This is Rietveld 408576698