src/compiler/mips64/code-generator-mips64.cc - Issue 2355743003: MIPS: [turbofan] Optimize sign-extension patterns like Sar(Shl(x, a), b)).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 2355743003: MIPS: [turbofan] Optimize sign-extension patterns like Sar(Shl(x, a), b)). (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/mips64/code-generator-mips64.cc

diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc

index 7a964801bbe03eff3d0dffa53b815784754beb16..ad6ee23ff9f01babbdb1a1a38856da195cbe8453 100644

--- a/src/compiler/mips64/code-generator-mips64.cc

+++ b/src/compiler/mips64/code-generator-mips64.cc

@@ -1641,6 +1641,12 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

break;

// ... more basic instructions ...

+ case kMips64Seb:

+ __ seb(i.OutputRegister(), i.InputRegister(0));

+ break;

+ case kMips64Seh:

+ __ seh(i.OutputRegister(), i.InputRegister(0));

+ break;

case kMips64Lbu:

__ lbu(i.OutputRegister(), i.MemoryOperand());

break;