Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2355413007: [Mac] Refactor the Fullscreen Toolbar (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years ago
Reviewers:
erikchen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Refactor the Fullscreen Toolbar - Split the FullscreenToolbarController into a layout manager with multiple trackers - Wrote tests

Patch Set 1 #

Patch Set 2 : Moving BWC logic to FSTBC #

Patch Set 3 : Added tests #

Patch Set 4 : Cleaning up #

Patch Set 5 : more refactoring and updated comments #

Patch Set 6 : More comments and more clean up #

Patch Set 7 : Nits and grits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1604 lines, -1251 lines) Patch
M base/mac/mac_util.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M base/mac/mac_util.mm View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 4 5 10 chunks +25 lines, -52 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 5 6 14 chunks +45 lines, -72 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 2 3 4 5 6 5 chunks +42 lines, -79 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 2 3 4 5 4 chunks +1 line, -32 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 4 5 11 chunks +31 lines, -107 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.h View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.h View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm View 1 2 3 4 5 6 1 chunk +155 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_manager.h View 1 2 3 4 5 6 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_manager.mm View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_layout_manager.h View 1 2 3 4 5 1 chunk +138 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_layout_manager.mm View 1 2 3 4 5 1 chunk +185 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_layout_unittest.mm View 1 2 3 4 5 1 chunk +287 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.h View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm View 1 2 3 4 5 1 chunk +130 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.h View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/fullscreen/immersive_fullscreen_controller.mm View 1 2 3 4 5 1 chunk +196 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h View 1 2 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm View 1 2 1 chunk +0 lines, -672 lines 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
spqchan
This CL is a bit big, so I'm thinking of splitting it up to make ...
4 years, 2 months ago (2016-10-18 22:34:51 UTC) #3
erikchen
On 2016/10/18 22:34:51, spqchan wrote: > This CL is a bit big, so I'm thinking ...
4 years, 2 months ago (2016-10-18 23:20:15 UTC) #4
spqchan
4 years, 2 months ago (2016-10-18 23:42:46 UTC) #5
On 2016/10/18 23:20:15, erikchen wrote:
> On 2016/10/18 22:34:51, spqchan wrote:
> > This CL is a bit big, so I'm thinking of splitting it up to make things
> easier.
> > 
> > I'm thinking of putting each tracking class in a separate CL and then have a
> > final CL will replace FullscreenToolbarController with
> > FullscreenToolbarLayoutManager.
> > 
> > If you're okay with not splitting it up though, I can leave it. Thoughts?
> 
> I would really appreciate it if you split this up. I can review this CL if you
> want, but I can't guarantee a thorough review of a CL of this magnitude.

Sounds good, I'll split this up.

Powered by Google App Engine
This is Rietveld 408576698