Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2355413007: [Mac] Refactor the Fullscreen Toolbar (Closed)
Patch Set: Nits and grits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index 0b6932737fef892615a3a9eb78334d5c72fd6992..8e97b701cb72b62ae292591ae96a2a4683b49b42 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -2798,7 +2798,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
![self isAnimatingToState:BookmarkBar::DETACHED]) {
BrowserWindowController* browserController =
[BrowserWindowController browserWindowControllerForView:[self view]];
- [browserController lockBarVisibilityForOwner:child withAnimation:NO];
+ [browserController lockToolbarVisibilityForOwner:child withAnimation:NO];
}
}
@@ -2807,7 +2807,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
// mode.
BrowserWindowController* browserController =
[BrowserWindowController browserWindowControllerForView:[self view]];
- [browserController releaseBarVisibilityForOwner:child withAnimation:NO];
+ [browserController releaseToolbarVisibilityForOwner:child withAnimation:NO];
}
// Add a new folder controller as triggered by the given folder button.
@@ -2818,8 +2818,8 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
BrowserWindowController* browserController =
[BrowserWindowController browserWindowControllerForView:[self view]];
// Confirm we're not re-locking with ourself as an owner before locking.
- DCHECK([browserController isBarVisibilityLockedForOwner:self] == NO);
- [browserController lockBarVisibilityForOwner:self withAnimation:NO];
+ DCHECK(![browserController isToolbarVisibilityLockedForOwner:self]);
+ [browserController lockToolbarVisibilityForOwner:self withAnimation:NO];
if (folderController_)
[self closeAllBookmarkFolders];
@@ -2838,7 +2838,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
[self watchForExitEvent:YES];
// No longer need to hold the lock; the folderController_ now owns it.
- [browserController releaseBarVisibilityForOwner:self withAnimation:NO];
+ [browserController releaseToolbarVisibilityForOwner:self withAnimation:NO];
}
- (void)openAll:(const BookmarkNode*)node
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698