chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm - Issue 2355413007: [Mac] Refactor the Fullscreen Toolbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

Issue 2355413007: [Mac] Refactor the Fullscreen Toolbar (Closed)

Patch Set: Nits and grits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm ('k') | chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

index 84305cd1ba64c6692f7e5f3afb6c58d0d884773c..21aacb5f9b7bc8fcdd3500e8afd748aa82461f77 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

@@ -285,8 +285,8 @@ class BookmarkEditorBaseControllerBridge

// Lock down floating bar when in full-screen mode. Don't animate

// otherwise the pane will be misplaced.

[[BrowserWindowController browserWindowControllerForWindow:parentWindow_]

- lockBarVisibilityForOwner:self

- withAnimation:NO];

+ lockToolbarVisibilityForOwner:self

+ withAnimation:NO];

[NSApp beginSheet:[self window]

modalForWindow:parentWindow_

modalDelegate:self

@@ -333,8 +333,8 @@ NSString* const kOkEnabledName = @"okEnabled";

contextInfo:(void*)contextInfo {

[sheet close];

[[BrowserWindowController browserWindowControllerForWindow:parentWindow_]

- releaseBarVisibilityForOwner:self

- withAnimation:YES];

+ releaseToolbarVisibilityForOwner:self

+ withAnimation:YES];

}

- (void)windowWillClose:(NSNotification*)notification {