Fix lost store side effects with escape analysis.

Fix lost store side effects with escape analysis.

This preserves side effects from stores in HCapturedObject markers so
that simulates following these markers are not merged away.

R=titzer@chromium.org
TEST=mjsunit/compiler/escape-analysis --deopt-every-n-times [3,6,9]

Committed: http://code.google.com/p/v8/source/detail?r=16394

[titzer, 2013-08-28 12:17:03]

lgtm

https://codereview.chromium.org/23554003/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/23554003/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:3230: gvn_flags_ = store->gvn_flags();
Maybe union instead of overwriting? I think CapturedObject has no side effects
currently, but might be more future-safe...

[Michael Starzinger, 2013-08-28 12:25:42]

Addressed comments. Landing.

https://codereview.chromium.org/23554003/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/23554003/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:3230: gvn_flags_ = store->gvn_flags();
On 2013/08/28 12:17:03, titzer wrote:
> Maybe union instead of overwriting? I think CapturedObject has no side effects
> currently, but might be more future-safe...

Done.

[Michael Starzinger, 2013-08-28 12:36:43]

Committed patchset #2 manually as r16394 (presubmit successful).