Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/hydrogen-instructions.h

Issue 23554003: Fix lost store side effects with escape analysis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ben Titzer. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-escape-analysis.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3206 matching lines...) Expand 10 before | Expand all | Expand 10 after
3217 values_.AddBlock(NULL, length, zone); // Resize list. 3217 values_.AddBlock(NULL, length, zone); // Resize list.
3218 } 3218 }
3219 3219
3220 // The values contain a list of all in-object properties inside the 3220 // The values contain a list of all in-object properties inside the
3221 // captured object and is index by field index. Properties in the 3221 // captured object and is index by field index. Properties in the
3222 // properties or elements backing store are not tracked here. 3222 // properties or elements backing store are not tracked here.
3223 const ZoneList<HValue*>* values() const { return &values_; } 3223 const ZoneList<HValue*>* values() const { return &values_; }
3224 int length() const { return values_.length(); } 3224 int length() const { return values_.length(); }
3225 int capture_id() const { return capture_id_; } 3225 int capture_id() const { return capture_id_; }
3226 3226
3227 void ReuseSideEffectsFromStore(HInstruction* store) {
3228 ASSERT(store->HasObservableSideEffects());
3229 ASSERT(store->IsStoreNamedField());
3230 gvn_flags_.Add(store->gvn_flags());
3231 }
3232
3227 // Replay effects of this instruction on the given environment. 3233 // Replay effects of this instruction on the given environment.
3228 void ReplayEnvironment(HEnvironment* env); 3234 void ReplayEnvironment(HEnvironment* env);
3229 3235
3230 DECLARE_CONCRETE_INSTRUCTION(CapturedObject) 3236 DECLARE_CONCRETE_INSTRUCTION(CapturedObject)
3231 3237
3232 private: 3238 private:
3233 int capture_id_; 3239 int capture_id_;
3234 }; 3240 };
3235 3241
3236 3242
(...skipping 3607 matching lines...) Expand 10 before | Expand all | Expand 10 after
6844 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 6850 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
6845 }; 6851 };
6846 6852
6847 6853
6848 #undef DECLARE_INSTRUCTION 6854 #undef DECLARE_INSTRUCTION
6849 #undef DECLARE_CONCRETE_INSTRUCTION 6855 #undef DECLARE_CONCRETE_INSTRUCTION
6850 6856
6851 } } // namespace v8::internal 6857 } } // namespace v8::internal
6852 6858
6853 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6859 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen-escape-analysis.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698