Use enum for per thread heap enabled flag

Use enum for per thread heap enabled flag

Using enum instead of a bool for per thread heap enabled flag

BUG=591606
Committed: https://crrev.com/e2ca66fcac787dd082c15057225ac82bf7a3c0f7
Cr-Commit-Position: refs/heads/master@{#420026}

[keishi, 2016-09-21 03:50:52]

The CQ bit was checked by keishi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 03:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[keishi, 2016-09-21 04:54:30]

keishi@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org

[keishi, 2016-09-21 04:54:30]

PTAL

[haraken, 2016-09-21 04:56:42]

LGTM

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.h (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.h:119: enum ThreadHeapMode {

Move this to BlinkGC.h.

[commit-bot: I haz the power, 2016-09-21 05:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:07:50]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-09-21 05:15:26]

nhiroki@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2016-09-21 05:15:26]

LGTM with minor comments. Thank you for addressing this.

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/WebThreadSupportingGC.h (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/WebThreadSupportingGC.h:89: ThreadHeapMode
m_threadHeapMode;
const?

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:204: NOTREACHED();
Is "default" case necessary?

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.h (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.h:548:
ThreadState(ThreadHeapMode);
explicit

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.h:658: ThreadHeapMode
m_threadHeapMode;
const?

[keishi, 2016-09-21 07:06:37]

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/WebThreadSupportingGC.h (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/WebThreadSupportingGC.h:89: ThreadHeapMode
m_threadHeapMode;
On 2016/09/21 05:15:26, nhiroki wrote:
> const?

Done.

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:204: NOTREACHED();
On 2016/09/21 05:15:26, nhiroki wrote:
> Is "default" case necessary?

Removed.

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.h (right):

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.h:119: enum ThreadHeapMode {
On 2016/09/21 04:56:42, haraken wrote:
> 
> Move this to BlinkGC.h.

Done.

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.h:548:
ThreadState(ThreadHeapMode);
On 2016/09/21 05:15:26, nhiroki wrote:
> explicit

Done.

https://codereview.chromium.org/2355193002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.h:658: ThreadHeapMode
m_threadHeapMode;
On 2016/09/21 05:15:26, nhiroki wrote:
> const?

Done.

[keishi, 2016-09-21 07:37:46]

The CQ bit was checked by keishi@chromium.org

[keishi, 2016-09-21 07:37:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2355193002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-09-21 07:38:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 11:17:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 11:18:59]

Description was changed from

==========
Use enum for per thread heap enabled flag

Using enum instead of a bool for per thread heap enabled flag

BUG=591606
==========

to

==========
Use enum for per thread heap enabled flag

Using enum instead of a bool for per thread heap enabled flag

BUG=591606

Committed: https://crrev.com/e2ca66fcac787dd082c15057225ac82bf7a3c0f7
Cr-Commit-Position: refs/heads/master@{#420026}
==========

[commit-bot: I haz the power, 2016-09-21 11:19:00]

Patchset 2 (id:??) landed as
https://crrev.com/e2ca66fcac787dd082c15057225ac82bf7a3c0f7
Cr-Commit-Position: refs/heads/master@{#420026}