Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/platform/WebThreadSupportingGC.h

Issue 2355193002: Use enum for per thread heap enabled flag (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/WebThreadSupportingGC.h
diff --git a/third_party/WebKit/Source/platform/WebThreadSupportingGC.h b/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
index 598afe5a3d06d819fd29a02f198b40e0342469a1..16aaea5b585c0d5923f9b33abbbdc92c97fb5054 100644
--- a/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
+++ b/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
@@ -28,8 +28,8 @@ class PLATFORM_EXPORT WebThreadSupportingGC final {
USING_FAST_MALLOC(WebThreadSupportingGC);
WTF_MAKE_NONCOPYABLE(WebThreadSupportingGC);
public:
- static std::unique_ptr<WebThreadSupportingGC> create(const char* name, bool perThreadHeapEnabled = false);
- static std::unique_ptr<WebThreadSupportingGC> createForThread(WebThread*, bool perThreadHeapEnabled = false);
+ static std::unique_ptr<WebThreadSupportingGC> create(const char* name, BlinkGC::ThreadHeapMode);
+ static std::unique_ptr<WebThreadSupportingGC> createForThread(WebThread*, BlinkGC::ThreadHeapMode);
~WebThreadSupportingGC();
void postTask(const WebTraceLocation& location, std::unique_ptr<WTF::Closure> task)
@@ -77,7 +77,7 @@ public:
}
private:
- WebThreadSupportingGC(const char* name, WebThread*, bool perThreadHeapEnabled);
+ WebThreadSupportingGC(const char* name, WebThread*, BlinkGC::ThreadHeapMode);
std::unique_ptr<GCTaskRunner> m_gcTaskRunner;
@@ -86,7 +86,7 @@ private:
// existing thread via createForThread().
WebThread* m_thread = nullptr;
std::unique_ptr<WebThread> m_owningThread;
- bool m_perThreadHeapEnabled;
+ const BlinkGC::ThreadHeapMode m_threadHeapMode;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698