third_party/WebKit/Source/platform/heap/Heap.cpp - Issue 2355193002: Use enum for per thread heap enabled flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.cpp

Issue 2355193002: Use enum for per thread heap enabled flag (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Heap.cpp

diff --git a/third_party/WebKit/Source/platform/heap/Heap.cpp b/third_party/WebKit/Source/platform/heap/Heap.cpp

index bd3819fcb15931f2ec700d1170fef52f838932fb..644068eeef94e5ca4b7361d29aa53f9d9fb8a85b 100644

--- a/third_party/WebKit/Source/platform/heap/Heap.cpp

+++ b/third_party/WebKit/Source/platform/heap/Heap.cpp

@@ -284,7 +284,7 @@ void ThreadHeap::detach(ThreadState* thread)

// be the main thread for the mainThreadHeap and a per thread heap enabled

// thread otherwise.

if (isLastThread)

- DCHECK(thread->perThreadHeapEnabled() || thread->isMainThread());

+ DCHECK(thread->threadHeapMode() == BlinkGC::PerThreadHeapMode || thread->isMainThread());

if (thread->isMainThread())

DCHECK_EQ(heapStats().allocatedSpace(), 0u);

if (isLastThread)