Separate ash::test::DisplayManagerTestApi from ash

Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
Committed: https://crrev.com/980ccfd4388c98b39813e0570b93502e9b053c50
Cr-Commit-Position: refs/heads/master@{#423586}

[rjkroege, 2016-09-30 18:29:55]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled dependencies,
decouple DisplayManagerTestApi from the rest of ash. This will permit
relocating ash::DisplayManager and its test code to ui.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled dependencies,
decouple DisplayManagerTestApi from the rest of ash. Also, modify all ash
display tests to obtain the current display
manager from the test harness so once the ash::DisplayManager
is relocated to ui/display, it can be provided to the tests via
injection. This will permit relocating ash::DisplayManager and its
test code to ui.

BUG=581462
==========

[rjkroege, 2016-09-30 18:30:23]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled dependencies,
decouple DisplayManagerTestApi from the rest of ash. Also, modify all ash
display tests to obtain the current display
manager from the test harness so once the ash::DisplayManager
is relocated to ui/display, it can be provided to the tests via
injection. This will permit relocating ash::DisplayManager and its
test code to ui.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of ash. Also, modify
all ash display tests to obtain the current display
manager from the test harness so once the ash::DisplayManager
is relocated to ui/display, it can be provided to the tests via
injection. This will permit relocating ash::DisplayManager and its
test code to ui.

BUG=581462
==========

[rjkroege, 2016-09-30 18:30:38]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of ash. Also, modify
all ash display tests to obtain the current display
manager from the test harness so once the ash::DisplayManager
is relocated to ui/display, it can be provided to the tests via
injection. This will permit relocating ash::DisplayManager and its
test code to ui.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of ash.
Also, modify all ash display tests to obtain the current display
manager from the test harness so once the ash::DisplayManager
is relocated to ui/display, it can be provided to the tests via
injection. This will permit relocating ash::DisplayManager and its
test code to ui.

BUG=581462
==========

[rjkroege, 2016-09-30 18:33:50]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of ash.
Also, modify all ash display tests to obtain the current display
manager from the test harness so once the ash::DisplayManager
is relocated to ui/display, it can be provided to the tests via
injection. This will permit relocating ash::DisplayManager and its
test code to ui.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from their instead from a global singleton.

The combination of these changes permits relocating ash::DisplayManager to
ui/display.

BUG=581462
==========

[rjkroege, 2016-09-30 18:34:12]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from their instead from a global singleton.

The combination of these changes permits relocating ash::DisplayManager to
ui/display.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from their instead from a global singleton.

The combination of these changes permits relocating ash::DisplayManager
to ui/display.

BUG=581462
==========

[rjkroege, 2016-09-30 18:34:29]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from their instead from a global singleton.

The combination of these changes permits relocating ash::DisplayManager
to ui/display.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from their instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
==========

[rjkroege, 2016-09-30 18:34:49]

rjkroege@chromium.org changed reviewers:
+ oshima@chromium.org

[rjkroege, 2016-09-30 18:34:50]

ptal

[rjkroege, 2016-09-30 18:35:02]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 18:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:08:15]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-10-04 00:47:17]

lgtm with nits

https://codereview.chromium.org/2355063002/diff/40001/ash/display/display_man...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/display/display_man...
ash/display/display_manager.h:352: const display::Display& GetSecondaryDisplay()
const;
just fyi: "swap display" is a legacy feature we added long time ago before
adding multi display, to allow switching which display to use. We probably
should remove it at some point.

https://codereview.chromium.org/2355063002/diff/40001/ash/display/root_window...
File ash/display/root_window_transformers_unittest.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/display/root_window...
ash/display/root_window_transformers_unittest.cc:117:
~RootWindowTransformersTest() override{};
space before {}

https://codereview.chromium.org/2355063002/diff/40001/ash/display/root_window...
ash/display/root_window_transformers_unittest.cc:136: };
DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/2355063002/diff/40001/ash/display/window_tree...
File ash/display/window_tree_host_manager_unittest.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/display/window_tree...
ash/display/window_tree_host_manager_unittest.cc:196:
TestHelper(test::AshTestBase* delegate);
explicit

https://codereview.chromium.org/2355063002/diff/40001/ash/test/display_manage...
File ash/test/display_manager_test_api.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/test/display_manage...
ash/test/display_manager_test_api.cc:146: #if 0
remove this

https://codereview.chromium.org/2355063002/diff/40001/ash/test/display_manage...
ash/test/display_manager_test_api.cc:160: display::DisplayIdList list =
display_manager->GetCurrentDisplayIdList();
I think this is just overlooked in the past. please remove this.

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/display/display_preferences_unittest.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/display_preferences_unittest.cc:21: //#include
"ash/screen_util.h"
remove this

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/display_preferences_unittest.cc:224:
ash::Shell::GetInstance()->display_manager();
indent (you can just run git cl format)

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_chromeos_unittest.cc:13:
//#include "ash/screen_util.h"
remove this

[rjkroege, 2016-10-05 00:21:44]

rjkroege@chromium.org changed reviewers:
+ achuith@chromium.org, lazyboy@chromium.org, msw@chromium.org

[rjkroege, 2016-10-05 00:21:46]

plus additional owners review:

lazyboy@ for chrome/browser/extensions/*
achuith@ for chrome/browser/ui/webui/options/chromeos/*
msw@ for chrome/browser/ui/window_sizer/*

https://codereview.chromium.org/2355063002/diff/40001/ash/display/display_man...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/display/display_man...
ash/display/display_manager.h:352: const display::Display& GetSecondaryDisplay()
const;
On 2016/10/04 00:47:16, oshima wrote:
> just fyi: "swap display" is a legacy feature we added long time ago before
> adding multi display, to allow switching which display to use. We probably
> should remove it at some point.

I added a TODO.

https://codereview.chromium.org/2355063002/diff/40001/ash/display/root_window...
File ash/display/root_window_transformers_unittest.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/display/root_window...
ash/display/root_window_transformers_unittest.cc:117:
~RootWindowTransformersTest() override{};
On 2016/10/04 00:47:16, oshima wrote:
> space before {}

Done.

https://codereview.chromium.org/2355063002/diff/40001/ash/display/root_window...
ash/display/root_window_transformers_unittest.cc:136: };
On 2016/10/04 00:47:16, oshima wrote:
> DISALLOW_COPY_AND_ASSIGN
> 

Done.

https://codereview.chromium.org/2355063002/diff/40001/ash/display/window_tree...
File ash/display/window_tree_host_manager_unittest.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/display/window_tree...
ash/display/window_tree_host_manager_unittest.cc:196:
TestHelper(test::AshTestBase* delegate);
On 2016/10/04 00:47:16, oshima wrote:
> explicit

Done.

https://codereview.chromium.org/2355063002/diff/40001/ash/test/display_manage...
File ash/test/display_manager_test_api.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/ash/test/display_manage...
ash/test/display_manager_test_api.cc:146: #if 0
On 2016/10/04 00:47:16, oshima wrote:
> remove this

Oops. done.

https://codereview.chromium.org/2355063002/diff/40001/ash/test/display_manage...
ash/test/display_manager_test_api.cc:160: display::DisplayIdList list =
display_manager->GetCurrentDisplayIdList();
On 2016/10/04 00:47:16, oshima wrote:
> I think this is just overlooked in the past. please remove this.

Done.

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/display/display_preferences_unittest.cc (right):

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/display_preferences_unittest.cc:21: //#include
"ash/screen_util.h"
On 2016/10/04 00:47:16, oshima wrote:
> remove this

Done.

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/display_preferences_unittest.cc:224:
ash::Shell::GetInstance()->display_manager();
On 2016/10/04 00:47:16, oshima wrote:
> indent (you can just run git cl format)

Done.

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2355063002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_chromeos_unittest.cc:13:
//#include "ash/screen_util.h"
On 2016/10/04 00:47:16, oshima wrote:
> remove this

Done.

[lazyboy, 2016-10-05 00:27:07]

chrome/browser/extensions/* RS LGTM.

[msw, 2016-10-05 00:33:58]

chrome/browser/ui/window_sizer/* lgtm

[rjkroege, 2016-10-05 00:47:48]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from their instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
==========

[achuithb, 2016-10-05 02:38:10]

https://codereview.chromium.org/2355063002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/2355063002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:19:
//#include "ash/screen_util.h"
What's this?

[rjkroege, 2016-10-05 19:07:31]

ptal

https://codereview.chromium.org/2355063002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/2355063002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:19:
//#include "ash/screen_util.h"
On 2016/10/05 02:38:10, achuithb wrote:
> What's this?

bad rebase. Fixed.

[achuithb, 2016-10-05 22:13:46]

On 2016/10/05 19:07:31, rjkroege wrote:
> ptal
> 
>
https://codereview.chromium.org/2355063002/diff/60001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
> (right):
> 
>
https://codereview.chromium.org/2355063002/diff/60001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:19:
> //#include "ash/screen_util.h"
> On 2016/10/05 02:38:10, achuithb wrote:
> > What's this?
> 
> bad rebase. Fixed.

lgtm

[rjkroege, 2016-10-06 17:20:37]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-10-06 17:20:38]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
lazyboy@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2355063002/#ps80001
(title: "review comment")

[commit-bot: I haz the power, 2016-10-06 17:21:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:00:43]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
==========

[commit-bot: I haz the power, 2016-10-06 18:00:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-06 18:05:04]

Description was changed from

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462
==========

to

==========
Separate ash::test::DisplayManagerTestApi from ash

To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.

The combination of these changes permits relocating
ash::DisplayManager to ui/display.

BUG=581462

Committed: https://crrev.com/980ccfd4388c98b39813e0570b93502e9b053c50
Cr-Commit-Position: refs/heads/master@{#423586}
==========

[commit-bot: I haz the power, 2016-10-06 18:05:05]

Patchset 5 (id:??) landed as
https://crrev.com/980ccfd4388c98b39813e0570b93502e9b053c50
Cr-Commit-Position: refs/heads/master@{#423586}