Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: ash/wm/window_util_unittest.cc

Issue 2355063002: Separate ash::test::DisplayManagerTestApi from ash (Closed)
Patch Set: review comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/wm/window_util.cc ('k') | ash/wm/workspace/workspace_event_handler_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/window_util.h" 5 #include "ash/wm/window_util.h"
6 6
7 #include "ash/aura/wm_window_aura.h" 7 #include "ash/aura/wm_window_aura.h"
8 #include "ash/common/wm/window_positioning_utils.h" 8 #include "ash/common/wm/window_positioning_utils.h"
9 #include "ash/common/wm/window_state.h" 9 #include "ash/common/wm/window_state.h"
10 #include "ash/screen_util.h" 10 #include "ash/display/display_manager.h"
11 #include "ash/test/ash_test_base.h" 11 #include "ash/test/ash_test_base.h"
12 #include "ash/wm/window_state_aura.h" 12 #include "ash/wm/window_state_aura.h"
13 #include "ui/aura/window.h" 13 #include "ui/aura/window.h"
14 #include "ui/display/screen.h"
14 15
15 namespace ash { 16 namespace ash {
16 17
17 namespace { 18 namespace {
18 19
19 std::string GetAdjustedBounds(const gfx::Rect& visible, 20 std::string GetAdjustedBounds(const gfx::Rect& visible,
20 gfx::Rect to_be_adjusted) { 21 gfx::Rect to_be_adjusted) {
21 wm::AdjustBoundsToEnsureMinimumWindowVisibility(visible, &to_be_adjusted); 22 wm::AdjustBoundsToEnsureMinimumWindowVisibility(visible, &to_be_adjusted);
22 return to_be_adjusted.ToString(); 23 return to_be_adjusted.ToString();
23 } 24 }
(...skipping 11 matching lines...) Expand all
35 36
36 wm::WindowState* window_state = wm::GetWindowState(window.get()); 37 wm::WindowState* window_state = wm::GetWindowState(window.get());
37 EXPECT_FALSE(window_state->bounds_changed_by_user()); 38 EXPECT_FALSE(window_state->bounds_changed_by_user());
38 39
39 wm::CenterWindow(WmWindowAura::Get(window.get())); 40 wm::CenterWindow(WmWindowAura::Get(window.get()));
40 // Centring window is considered as a user's action. 41 // Centring window is considered as a user's action.
41 EXPECT_TRUE(window_state->bounds_changed_by_user()); 42 EXPECT_TRUE(window_state->bounds_changed_by_user());
42 EXPECT_EQ("200,126 100x100", window->bounds().ToString()); 43 EXPECT_EQ("200,126 100x100", window->bounds().ToString());
43 EXPECT_EQ("200,126 100x100", window->GetBoundsInScreen().ToString()); 44 EXPECT_EQ("200,126 100x100", window->GetBoundsInScreen().ToString());
44 window->SetBoundsInScreen(gfx::Rect(600, 0, 100, 100), 45 window->SetBoundsInScreen(gfx::Rect(600, 0, 100, 100),
45 ScreenUtil::GetSecondaryDisplay()); 46 display_manager()->GetSecondaryDisplay());
46 wm::CenterWindow(WmWindowAura::Get(window.get())); 47 wm::CenterWindow(WmWindowAura::Get(window.get()));
47 EXPECT_EQ("250,126 100x100", window->bounds().ToString()); 48 EXPECT_EQ("250,126 100x100", window->bounds().ToString());
48 EXPECT_EQ("750,126 100x100", window->GetBoundsInScreen().ToString()); 49 EXPECT_EQ("750,126 100x100", window->GetBoundsInScreen().ToString());
49 } 50 }
50 51
51 TEST_F(WindowUtilTest, AdjustBoundsToEnsureMinimumVisibility) { 52 TEST_F(WindowUtilTest, AdjustBoundsToEnsureMinimumVisibility) {
52 const gfx::Rect visible_bounds(0, 0, 100, 100); 53 const gfx::Rect visible_bounds(0, 0, 100, 100);
53 54
54 EXPECT_EQ("0,0 90x90", 55 EXPECT_EQ("0,0 90x90",
55 GetAdjustedBounds(visible_bounds, gfx::Rect(0, 0, 90, 90))); 56 GetAdjustedBounds(visible_bounds, gfx::Rect(0, 0, 90, 90)));
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 "-250,-40 100x100", 106 "-250,-40 100x100",
106 GetAdjustedBounds(visible_bounds_left, gfx::Rect(-250, -40, 150, 150))); 107 GetAdjustedBounds(visible_bounds_left, gfx::Rect(-250, -40, 150, 150)));
107 EXPECT_EQ( 108 EXPECT_EQ(
108 "-275,-50 100x100", 109 "-275,-50 100x100",
109 GetAdjustedBounds(visible_bounds_left, gfx::Rect(-400, -60, 150, 150))); 110 GetAdjustedBounds(visible_bounds_left, gfx::Rect(-400, -60, 150, 150)));
110 EXPECT_EQ("-125,0 100x100", 111 EXPECT_EQ("-125,0 100x100",
111 GetAdjustedBounds(visible_bounds_left, gfx::Rect(0, 0, 150, 150))); 112 GetAdjustedBounds(visible_bounds_left, gfx::Rect(0, 0, 150, 150)));
112 } 113 }
113 114
114 } // namespace ash 115 } // namespace ash
OLDNEW
« no previous file with comments | « ash/wm/window_util.cc ('k') | ash/wm/workspace/workspace_event_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698