Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: Source/core/html/HTMLOptionsCollection.idl

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLOptionsCollection.idl
diff --git a/Source/core/html/HTMLOptionsCollection.idl b/Source/core/html/HTMLOptionsCollection.idl
index 9f32344a163dddaef1de92b85870bb127c7f6b86..8e5a3b9b8d76ce4cdcf1bfba5b12c6f4f52a1c71 100644
--- a/Source/core/html/HTMLOptionsCollection.idl
+++ b/Source/core/html/HTMLOptionsCollection.idl
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -32,6 +33,7 @@
[Custom, RaisesException] void add([Default=Undefined] optional HTMLOptionElement option,
optional unsigned long index);
- [Custom] void remove([Default=Undefined] optional unsigned long index);
+ void remove([Default=Undefined] optional unsigned long index);
arv (Not doing code reviews) 2013/08/29 13:33:23 We should make this non optional as required by th
do-not-use 2013/08/29 14:27:23 HTMLOptionsCollection is not an Element, therefore
+ void remove(HTMLOptionElement option); // Non standard.
};

Powered by Google App Engine
This is Rietveld 408576698