Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLSelectElement.idl
diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl
index 6a511b24eb25573907dda03d9f86dae02a0e6580..8c92af58db4ff67f59947a96a82166cd61fd4622 100644
--- a/Source/core/html/HTMLSelectElement.idl
+++ b/Source/core/html/HTMLSelectElement.idl
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -37,9 +38,9 @@ interface HTMLSelectElement : HTMLElement {
Node namedItem([Default=Undefined] optional DOMString name);
[RaisesException] void add([Default=Undefined] optional HTMLElement element,
[Default=Undefined] optional HTMLElement before);
- // In JavaScript, we support both option index and option object parameters.
- // As of this writing this cannot be auto-generated.
- [Custom] void remove(/* indexOrOption */);
+ void remove(long index);
+ void remove(HTMLOptionElement option); // Non standard.
+ [RaisesException] void remove();
haraken 2013/08/29 07:52:50 Don't you need to add [RaisesException] to other o
do-not-use 2013/08/29 07:55:27 Why? the others do not throw. Only the one from Ch
haraken 2013/08/29 08:12:56 Sorry, I misread the implementation. You're right.
readonly attribute HTMLCollection selectedOptions;
attribute long selectedIndex;
[TreatNullAs=NullString] attribute DOMString value;
« Source/core/html/HTMLOptionsCollection.idl ('K') | « Source/core/html/HTMLSelectElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698