Source/core/html/HTMLOptionsCollection.cpp - Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.cpp

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionsCollection.cpp

diff --git a/Source/core/html/HTMLOptionsCollection.cpp b/Source/core/html/HTMLOptionsCollection.cpp

index 13e9f6c38153c5bef63ade3eb8921637a1a94a17..ea2c28c4463b5731ab89546460dec77196054fd8 100644

--- a/Source/core/html/HTMLOptionsCollection.cpp

+++ b/Source/core/html/HTMLOptionsCollection.cpp

@@ -75,6 +75,11 @@ void HTMLOptionsCollection::remove(int index)

toHTMLSelectElement(ownerNode())->remove(index);

}

+void HTMLOptionsCollection::remove(HTMLOptionElement* option)

+ return remove(option->index());

int HTMLOptionsCollection::selectedIndex() const

{

return toHTMLSelectElement(ownerNode())->selectedIndex();