Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2354673005: Set enable_swiftshader arg on Chrome-branded windows builds. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Set enable_swiftshader arg on Chrome-branded windows builds. This matches the previous behavior with gyp (which was necessitated by the need for a registration key). In the future we can expand this to other platforms and to regular Chromium. BUG=646660 Review-Url: https://codereview.chromium.org/2345783003 Cr-Commit-Position: refs/heads/master@{#419032} (cherry picked from commit b9e58c8a08f405d1bc8c09e21ab635cf4db1348b) Committed: https://chromium.googlesource.com/chromium/src/+/9cc48e838a4be1a72db6aa2f42e65eff5f9f3083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
4 years, 3 months ago (2016-09-19 22:11:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cc48e838a4be1a72db6aa2f42e65eff5f9f3083.

Powered by Google App Engine
This is Rietveld 408576698