Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2345783003: Set enable_swiftshader arg on Chrome-branded windows builds. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fixswiftshaderflag
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set enable_swiftshader arg on Chrome-branded windows builds. This matches the previous behavior with gyp (which was necessitated by the need for a registration key). In the future we can expand this to other platforms and to regular Chromium. BUG=646660 Committed: https://crrev.com/b9e58c8a08f405d1bc8c09e21ab635cf4db1348b Cr-Commit-Position: refs/heads/master@{#419032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
jbauman
4 years, 3 months ago (2016-09-15 19:24:51 UTC) #3
jbauman
4 years, 3 months ago (2016-09-15 19:54:48 UTC) #6
Ken Russell (switch to Gerrit)
lgtm
4 years, 3 months ago (2016-09-15 23:07:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345783003/1
4 years, 3 months ago (2016-09-15 23:09:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 23:14:44 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 23:16:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9e58c8a08f405d1bc8c09e21ab635cf4db1348b
Cr-Commit-Position: refs/heads/master@{#419032}

Powered by Google App Engine
This is Rietveld 408576698