Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2354613005: Android: Reword the "leaving incognito" dialog. (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, rolfe
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Reword the "leaving incognito" dialog. The previous wording was very unclear. The new dialog asks a specific question, explains what is about to happen, and provides the user with clear responses, as per the MD spec. BUG=587306 Review-Url: https://codereview.chromium.org/2354613005 Cr-Commit-Position: refs/heads/master@{#461025} Committed: https://chromium.googlesource.com/chromium/src/+/1d18c5d69956016f711094666eeb9592b540004e

Patch Set 1 #

Patch Set 2 : Shorten string, avoid redundancy. #

Patch Set 3 : Update descriptions. #

Patch Set 4 : Rebase. #

Patch Set 5 : Change Cancel/Continue to Stay/Leave. #

Patch Set 6 : Rebase onto 2354833002. #

Patch Set 7 : Rebase. #

Patch Set 8 : Rebase. #

Patch Set 9 : Rebase. #

Patch Set 10 : Rebase. #

Patch Set 11 : Format ExternalNavigationDelegateImpl.java. #

Patch Set 12 : Updated string (and description) with UX-approved text. #

Patch Set 13 : Bumped char limit to 32, since this text is longer now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -24 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 2 3 4 5 6 7 8 9 10 1 chunk +23 lines, -20 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Matt Giuca
rolfe: For UX / strings approval. tedchoc: Owners. See before/after screenshots on bug: https://bugs.chromium.org/p/chromium/issues/detail?id=587306#c23
4 years, 3 months ago (2016-09-20 05:53:31 UTC) #2
Matt Giuca
Closing CL (will go through more discussion).
4 years, 2 months ago (2016-10-07 01:59:33 UTC) #4
Matt Giuca
Hi Ted, After 6 months we finally got UX approval for a new string. See ...
3 years, 8 months ago (2017-03-30 01:57:08 UTC) #6
Ted C
lgtm!
3 years, 8 months ago (2017-03-30 16:44:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354613005/240001
3 years, 8 months ago (2017-03-31 03:39:05 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 04:21:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/1d18c5d69956016f711094666eeb...

Powered by Google App Engine
This is Rietveld 408576698