Enable ANGLE ES3 by default in Chromium (Windows)

Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342
Cr-Commit-Position: refs/heads/master@{#420802}

[Zhenyao Mo, 2016-09-21 21:02:08]

Description was changed from

==========
Enable ES3 by default in ANGLE (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
==========

to

==========
Enable ES3 by default in ANGLE (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-09-21 21:05:42]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-09-21 21:08:01]

Please take a look.

[piman, 2016-09-21 21:09:48]

lgtm

[Ken Russell (switch to Gerrit), 2016-09-21 21:18:32]

LGTM with one slight caveat.

https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_context_egl.cc...
ui/gl/gl_context_egl.cc:57: switches::kDisableES3ANGLE)) {
Thinking about this more, perhaps the switch and driver bug workaround should be
named something like disable_default_es3? This code path is taken on more
platforms than Windows.

https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_switches.h
File ui/gl/gl_switches.h (right):

https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_switches.h#new...
ui/gl/gl_switches.h:34: GL_EXPORT extern const char kDisableES3ANGLE[];
Same comment here.

[Zhenyao Mo, 2016-09-21 21:38:06]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-09-21 21:39:06]

https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_context_egl.cc
File ui/gl/gl_context_egl.cc (right):

https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_context_egl.cc...
ui/gl/gl_context_egl.cc:57: switches::kDisableES3ANGLE)) {
On 2016/09/21 21:18:32, Ken Russell wrote:
> Thinking about this more, perhaps the switch and driver bug workaround should
be
> named something like disable_default_es3? This code path is taken on more
> platforms than Windows.

I suggest use "disable_es3_gl_context" instead, because in the future we will
have another switch like "disable_es3_command_buffer".

[commit-bot: I haz the power, 2016-09-21 22:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:39:01]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2016-09-22 00:42:01]

On 2016/09/21 21:39:06, Zhenyao Mo wrote:
> https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_context_egl.cc
> File ui/gl/gl_context_egl.cc (right):
> 
>
https://codereview.chromium.org/2354423002/diff/20001/ui/gl/gl_context_egl.cc...
> ui/gl/gl_context_egl.cc:57: switches::kDisableES3ANGLE)) {
> On 2016/09/21 21:18:32, Ken Russell wrote:
> > Thinking about this more, perhaps the switch and driver bug workaround
should
> be
> > named something like disable_default_es3? This code path is taken on more
> > platforms than Windows.
> 
> I suggest use "disable_es3_gl_context" instead, because in the future we will
> have another switch like "disable_es3_command_buffer".

SGTM.

[Ken Russell (switch to Gerrit), 2016-09-22 00:43:03]

LGTM. Like the new name.

Unfortunately the depth texture test failure will have to be resolved. Can you
ask the ANGLE team to help?

[Zhenyao Mo, 2016-09-23 23:21:30]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-09-23 23:21:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2354423002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-23 23:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-09-23 23:22:05]

ANGLE depth texture issue is fixed and rolled into chromium. Landing this now.

[Zhenyao Mo, 2016-09-23 23:24:41]

Description was changed from

==========
Enable ES3 by default in ANGLE (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-24 00:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 00:43:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Zhenyao Mo, 2016-09-24 00:50:10]

Description was changed from

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-09-24 00:50:16]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-09-24 00:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 00:54:50]

Description was changed from

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-24 00:54:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-24 00:56:56]

Description was changed from

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE ES3 by default in Chromium (Windows)

We can use --disable-es3-angle or driver bug workaround list to turn
it off if it's problematic on certain platforms.

BUG=649101
TEST=win bots
R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342
Cr-Commit-Position: refs/heads/master@{#420802}
==========

[commit-bot: I haz the power, 2016-09-24 00:56:57]

Patchset 4 (id:??) landed as
https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342
Cr-Commit-Position: refs/heads/master@{#420802}