Fix for test of linking with unused type parameter.

Fix for test of linking with unused type parameter.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5a668422ffb89e8b615b8ea302d282b7f86f238f

[Paul Berry, 2016-09-21 21:18:12]

https://codereview.chromium.org/2354383002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2354383002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:9957: if (!strongMode ||
skipFullyLinkedData) {
I'm concerned because this means we're no longer testing any behavior at all in
spec mode.  What happens in spec mode?  If it's different from strong mode, I
think we should just change this test so that it asserts the correct behavior
based on what mode it's in.

[scheglov, 2016-09-21 21:42:37]

https://codereview.chromium.org/2354383002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2354383002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:9957: if (!strongMode ||
skipFullyLinkedData) {
On 2016/09/21 21:18:12, Paul Berry wrote:
> I'm concerned because this means we're no longer testing any behavior at all
in
> spec mode.  What happens in spec mode?  If it's different from strong mode, I
> think we should just change this test so that it asserts the correct behavior
> based on what mode it's in.

The behavior is consistent with other *infer* tests. The EntityRef for
inferredReturnTypeSlot in non-strong mode is null, because inference happens
only in strong mode. The name of the test is no consistent though.

[Paul Berry, 2016-09-21 22:09:10]

lgtm

https://codereview.chromium.org/2354383002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2354383002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:9957: if (!strongMode ||
skipFullyLinkedData) {
On 2016/09/21 21:42:37, scheglov wrote:
> On 2016/09/21 21:18:12, Paul Berry wrote:
> > I'm concerned because this means we're no longer testing any behavior at all
> in
> > spec mode.  What happens in spec mode?  If it's different from strong mode,
I
> > think we should just change this test so that it asserts the correct
behavior
> > based on what mode it's in.
> 
> The behavior is consistent with other *infer* tests. The EntityRef for
> inferredReturnTypeSlot in non-strong mode is null, because inference happens
> only in strong mode. The name of the test is no consistent though.

Ah, sorry--I missed that detail.  Thanks.

[scheglov, 2016-09-22 01:04:40]

Description was changed from

==========
Fix for test of linking with unused type parameter.

R=paulberry@google.com
BUG=
==========

to

==========
Fix for test of linking with unused type parameter.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5a668422ffb89e8b615b8ea302d282b7f86f238f
==========

[scheglov, 2016-09-22 01:04:41]

Committed patchset #1 (id:1) manually as
5a668422ffb89e8b615b8ea302d282b7f86f238f (presubmit successful).