Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: pkg/analyzer/test/src/summary/summary_common.dart

Issue 2354383002: Fix for test of linking with unused type parameter. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/summarize_ast_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/summary_common.dart
diff --git a/pkg/analyzer/test/src/summary/summary_common.dart b/pkg/analyzer/test/src/summary/summary_common.dart
index 7115a73ec120549cc32a71b990b79b9c4f51b455..7d90d0a8e77d71cd448dd8cc4a12fc09fecc978f 100644
--- a/pkg/analyzer/test/src/summary/summary_common.dart
+++ b/pkg/analyzer/test/src/summary/summary_common.dart
@@ -9954,10 +9954,9 @@ typedef F();''';
}
test_unused_type_parameter() {
- if (skipFullyLinkedData) {
+ if (!strongMode || skipFullyLinkedData) {
Paul Berry 2016/09/21 21:18:12 I'm concerned because this means we're no longer t
scheglov 2016/09/21 21:42:37 The behavior is consistent with other *infer* test
Paul Berry 2016/09/21 22:09:10 Ah, sorry--I missed that detail. Thanks.
return;
}
- // Unused type parameters get converted to `dynamic`.
UnlinkedVariable variable = serializeVariableText('''
class C<T> {
void f() {}
@@ -9968,7 +9967,7 @@ var v = c.f;
EntityRef type =
getTypeRefForSlot(variable.initializer.inferredReturnTypeSlot);
expect(type.typeArguments, hasLength(1));
- checkLinkedTypeRef(type.typeArguments[0], null, null, 'dynamic');
+ checkLinkedTypeRef(type.typeArguments[0], 'dart:core', 'dart:core', 'int');
}
test_variable() {
« no previous file with comments | « pkg/analyzer/test/src/summary/summarize_ast_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698