Fix for test of linking with unused type parameter.

pkg/analyzer/test/src/summary/summary_common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.summary.summary_common;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/src/dart/scanner/reader.dart';
@@ skipping 9936 matching lines @@
   test_unresolved_reference_shared() {
     // Both `x` and `y` use unresolved identifier `C` as their type.  Verify
     // that they both use the same unresolved reference.
     serializeLibraryText('C x; C y;', allowErrors: true);
     EntityRef xType = findVariable('x').type;
     EntityRef yType = findVariable('y').type;
     expect(xType.reference, yType.reference);
   }
 
   test_unused_type_parameter() {
-    if (skipFullyLinkedData) {
+    if (!strongMode || skipFullyLinkedData) {

[Paul Berry, 2016/09/21 21:18:12]

I'm concerned because this means we're no longer testing any behavior at all in
spec mode.  What happens in spec mode?  If it's different from strong mode, I
think we should just change this test so that it asserts the correct behavior
based on what mode it's in.

[scheglov, 2016/09/21 21:42:37]

The behavior is consistent with other *infer* tests. The EntityRef for
inferredReturnTypeSlot in non-strong mode is null, because inference happens
only in strong mode. The name of the test is no consistent though.

[Paul Berry, 2016/09/21 22:09:10]

Ah, sorry--I missed that detail.  Thanks.

       return;
     }
-    // Unused type parameters get converted to `dynamic`.
     UnlinkedVariable variable = serializeVariableText('''
 class C<T> {
   void f() {}
 }
 C<int> c;
 var v = c.f;
 ''');
     EntityRef type =
         getTypeRefForSlot(variable.initializer.inferredReturnTypeSlot);
     expect(type.typeArguments, hasLength(1));
-    checkLinkedTypeRef(type.typeArguments[0], null, null, 'dynamic');
+    checkLinkedTypeRef(type.typeArguments[0], 'dart:core', 'dart:core', 'int');
   }
 
   test_variable() {
     String text = 'int i;';
     UnlinkedVariable v = serializeVariableText(text, variableName: 'i');
     expect(v.nameOffset, text.indexOf('i;'));
     expect(findExecutable('i'), isNull);
     expect(findExecutable('i='), isNull);
     expect(unlinkedUnits[0].publicNamespace.names, hasLength(2));
     expect(unlinkedUnits[0].publicNamespace.names[0].kind,
@@ skipping 356 matching lines @@
 class _PrefixExpectation {
   final ReferenceKind kind;
   final String name;
   final String absoluteUri;
   final String relativeUri;
   final int numTypeParameters;
 
   _PrefixExpectation(this.kind, this.name,
       {this.absoluteUri, this.relativeUri, this.numTypeParameters: 0});
 }