Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2354353002: Set up isolate in CFXJS_Engine's constructor (Closed)

Created:
4 years, 3 months ago by Wei Li
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Set up isolate in CFXJS_Engine's constructor CFXJS_Engine class should always be constructed with an isolate, except for its subclasses which may need to create an isolate by themselves. Move SetIsolate() function to be protected so that only subclasses can access it. Committed: https://pdfium.googlesource.com/pdfium/+/0b2a9874bddf44b4226fcbafa9ce159a9b3735a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M fxjs/fxjs_v8.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M fxjs/fxjs_v8_embeddertest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M fxjs/include/fxjs_v8.h View 3 chunks +6 lines, -3 lines 0 comments Download
M testing/js_embedder_test.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Wei Li
pls review, thanks
4 years, 3 months ago (2016-09-21 17:56:00 UTC) #6
Tom Sepez
Ok, this is a little bit cleaner. LGTM.
4 years, 3 months ago (2016-09-21 18:09:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354353002/1
4 years, 3 months ago (2016-09-21 18:50:27 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 18:50:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0b2a9874bddf44b4226fcbafa9ce159a9b37...

Powered by Google App Engine
This is Rietveld 408576698