fxjs/fxjs_v8.cpp - Issue 2354353002: Set up isolate in CFXJS_Engine's constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fxjs/fxjs_v8.cpp

Issue 2354353002: Set up isolate in CFXJS_Engine's constructor (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fxjs/fxjs_v8.cpp

diff --git a/fxjs/fxjs_v8.cpp b/fxjs/fxjs_v8.cpp

index 53042542423da0cb831ef043cd6b894b7b81caef..ebe38fdb7f74878a2ed3557c8255951c3cb5ad09 100644

--- a/fxjs/fxjs_v8.cpp

+++ b/fxjs/fxjs_v8.cpp

@@ -219,6 +219,8 @@ FXJS_PerIsolateData::FXJS_PerIsolateData() : m_pDynamicObjsMap(nullptr) {}

CFXJS_Engine::CFXJS_Engine() : m_isolate(nullptr) {}

+CFXJS_Engine::CFXJS_Engine(v8::Isolate* pIsolate) : m_isolate(pIsolate) {}

CFXJS_Engine::~CFXJS_Engine() {

m_V8PersistentContext.Reset();

}

« no previous file with comments | « no previous file | fxjs/fxjs_v8_embeddertest.cpp » ('j') | no next file with comments »