Issue 23542015: [chromedriver] Fallback to devtools for screenshotting of forbidden urls.

Issue 23542015: [chromedriver] Fallback to devtools for screenshotting of forbidden urls. (Closed)

Created:
7 years, 3 months ago by kkania

Modified:
7 years, 3 months ago

Reviewers:
chrisgao (Use stgao instead)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, frankf, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Fallback to devtools for screenshotting of forbidden urls. BUG=none R=chrisgao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222200

Patch Set 2 : . #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
M	chrome/test/chromedriver/chrome/automation_extension.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/automation_extension.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome/status.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/status.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/extension/background.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/window_commands.cc	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

chrisgao (Use stgao instead)

lgtm with nit. https://codereview.chromium.org/23542015/diff/1/chrome/test/chromedriver/window_commands.cc File chrome/test/chromedriver/window_commands.cc (right): https://codereview.chromium.org/23542015/diff/1/chrome/test/chromedriver/window_commands.cc#newcode746 chrome/test/chromedriver/window_commands.cc:746: if (status.code() != kForbidden) How about ...

7 years, 3 months ago (2013-09-09 22:56:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23542015/6001

7 years, 3 months ago (2013-09-10 00:02:33 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-10 00:34:26 UTC) #4

kkania

7 years, 3 months ago (2013-09-11 18:24:21 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/23542015/diff/1/chrome/test/chromedriver/wind...
File chrome/test/chromedriver/window_commands.cc (right):

https://codereview.chromium.org/23542015/diff/1/chrome/test/chromedriver/wind...
chrome/test/chromedriver/window_commands.cc:746: if (status.code() !=
kForbidden)
On 2013/09/09 22:56:04, chrisgao wrote:
> How about adding a comment for the special case?

Done.

Expand Messages | Collapse Messages