[chromedriver] Fallback to devtools for screenshotting of forbidden urls.

chrome/test/chromedriver/window_commands.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/window_commands.h"
 
 #include <list>
 #include <string>
 
 #include "base/callback.h"
@@ skipping 725 matching lines @@
     return status;
 
   std::string screenshot;
   if (session->chrome->GetType() == Chrome::DESKTOP &&
       !session->force_devtools_screenshot) {
     AutomationExtension* extension = NULL;
     Status status = session->chrome->GetAutomationExtension(&extension);
     if (status.IsError())
       return status;
     status = extension->CaptureScreenshot(&screenshot);
-    if (status.IsError())
-      return status;
-  } else {
-    Status status = web_view->CaptureScreenshot(&screenshot);
-    if (status.IsError())
+    if (status.code() != kForbidden)

[chrisgao (Use stgao instead), 2013/09/09 22:56:04]

How about adding a comment for the special case?

[kkania, 2013/09/11 18:24:21]

Done.

       return status;
   }
+
+  status = web_view->CaptureScreenshot(&screenshot);
+  if (status.IsError())
+    return status;
+
   value->reset(new base::StringValue(screenshot));
   return Status(kOk);
 }
 
 Status ExecuteGetCookies(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   std::list<Cookie> cookies;
@@ skipping 87 matching lines @@
     // |accuracy| is not part of the WebDriver spec yet, so if it is not given
     // default to 100 meters accuracy.
     geoposition.accuracy = 100;
   }
 
   Status status = web_view->OverrideGeolocation(geoposition);
   if (status.IsOk())
     session->overridden_geoposition.reset(new Geoposition(geoposition));
   return status;
 }