Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2622)

Unified Diff: chrome/test/chromedriver/extension/background.js

Issue 23542015: [chromedriver] Fallback to devtools for screenshotting of forbidden urls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/status.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/extension/background.js
diff --git a/chrome/test/chromedriver/extension/background.js b/chrome/test/chromedriver/extension/background.js
index 16ea857d1542de4dd13a14999b59eff04f43d480..9158d6f5d72672bafc3bf7260cfe83d7771ebddb 100644
--- a/chrome/test/chromedriver/extension/background.js
+++ b/chrome/test/chromedriver/extension/background.js
@@ -27,6 +27,13 @@ function checkForExtensionError(errCallback) {
*/
function captureScreenshot(callback, errCallback) {
chrome.tabs.captureVisibleTab({format:'png'}, function(dataUrl) {
+ if (chrome.extension.lastError &&
+ chrome.extension.lastError.message.indexOf('permission') != -1) {
+ var error = new Error(chrome.extension.lastError.message);
+ error.code = 103; // kForbidden
+ errCallback(error);
+ return;
+ }
checkForExtensionError(errCallback);
var base64 = ';base64,';
callback(dataUrl.substr(dataUrl.indexOf(base64) + base64.length))
« no previous file with comments | « chrome/test/chromedriver/chrome/status.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698