Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3826)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.h

Issue 23537029: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 2 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index 28943430d873e5126cd22ab7b8c597e752231822..2ec9c63618e8c696b7fd81d35b1dfb62d88c16f1 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -15,6 +15,7 @@
#include "chrome/browser/content_settings/content_settings_usages_state.h"
#include "chrome/browser/content_settings/local_shared_objects_container.h"
#include "chrome/browser/media/media_stream_devices_controller.h"
+#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/common/content_settings.h"
#include "chrome/common/content_settings_types.h"
#include "chrome/common/custom_handlers/protocol_handler.h"
@@ -26,7 +27,6 @@
#include "net/cookies/canonical_cookie.h"
class CookiesTreeModel;
-class PasswordFormManager;
class Profile;
namespace content {
@@ -295,13 +295,10 @@ class TabSpecificContentSettings
virtual void AppCacheAccessed(const GURL& manifest_url,
bool blocked_by_policy) OVERRIDE;
- // If user clicks on 'save password' this will have the password saved upon
- // the next navigation.
- bool PasswordAccepted();
-
- // If user clicks on 'never save password for this site' this have the
- // password blacklisted upon the next navigation.
- bool PasswordFormBlacklisted();
+ // Called when the chooses to save or blacklist a password. Instructs
+ // |form_to_save| to perfom the chosen action when the next navigation occurs
Peter Kasting 2013/09/11 21:49:39 Nit: form_to_save_ ? Perhaps this could be improv
npentrel 2013/09/12 10:08:44 Done.
+ // or when the tab is closed.
+ bool SetPasswordAction(PasswordFormManager::PasswordAction password_action);
// Message handlers. Public for testing.
void OnContentBlocked(ContentSettingsType type,
@@ -342,9 +339,9 @@ class TabSpecificContentSettings
const MediaStreamDevicesController::MediaStreamTypePermissionMap&
request_permissions);
- // This method is called to pass the |form_to_save| on a successful password
- // submission. It also updates the status of the save password content
- // setting.
+ // Called when a password form is submitted. |form_to_save| is the submitted
+ // form. This form can save or blacklist the login credentials via
+ // PasswordAccepted() and PasswordFormBlacklisted respectively.
Peter Kasting 2013/09/11 21:49:39 This comment is out of date; also see comments abo
npentrel 2013/09/12 10:08:44 Done.
void OnPasswordSubmitted(PasswordFormManager* form_to_save);
// There methods are called to update the status about MIDI access.

Powered by Google App Engine
This is Rietveld 408576698