Save password functionality added to the save password bubble

chrome/browser/content_settings/tab_specific_content_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "chrome/browser/content_settings/content_settings_usages_state.h"
 #include "chrome/browser/content_settings/local_shared_objects_container.h"
 #include "chrome/browser/media/media_stream_devices_controller.h"
+#include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/content_settings_types.h"
 #include "chrome/common/custom_handlers/protocol_handler.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "content/public/common/media_stream_request.h"
 #include "net/cookies/canonical_cookie.h"
 
 class CookiesTreeModel;
-class PasswordFormManager;
 class Profile;
 
 namespace content {
 class RenderViewHost;
 }
 
 namespace net {
 class CookieOptions;
 }
 
@@ skipping 248 matching lines @@
       int64 frame_id,
       int64 parent_frame_id,
       bool is_main_frame,
       const GURL& validated_url,
       bool is_error_page,
       bool is_iframe_srcdoc,
       content::RenderViewHost* render_view_host) OVERRIDE;
   virtual void AppCacheAccessed(const GURL& manifest_url,
                                 bool blocked_by_policy) OVERRIDE;
 
-  // If user clicks on 'save password' this will have the password saved upon
-  // the next navigation.
-  bool PasswordAccepted();
-
-  // If user clicks on 'never save password for this site' this have the
-  // password blacklisted upon the next navigation.
-  bool PasswordFormBlacklisted();
+  // Called when the chooses to save or blacklist a password. Instructs
+  // |form_to_save| to perfom the chosen action when the next navigation occurs

[Peter Kasting, 2013/09/11 21:49:39]

Nit: form_to_save_ ?  Perhaps this could be improved even more by naming this
member (and relevant setters, etc.) |form_manager_|, since that way the name
will imply that
(1) This is a management object, not a form itself.
(2) The management object may do something other than "save" on navigating.

[npentrel, 2013/09/12 10:08:44]

Done.

+  // or when the tab is closed.
+  bool SetPasswordAction(PasswordFormManager::PasswordAction password_action);
 
   // Message handlers. Public for testing.
   void OnContentBlocked(ContentSettingsType type,
                         const std::string& resource_identifier);
   void OnContentAllowed(ContentSettingsType type);
 
   // These methods are invoked on the UI thread by the static functions above.
   // Public for testing.
   void OnCookiesRead(const GURL& url,
                      const GURL& first_party_url,
@@ skipping 20 matching lines @@
                                   bool allowed);
 
   // This method is called to update the status about the microphone and
   // camera stream access. |request_permissions| contains a list of requested
   // media stream types and the permission for each type.
   void OnMediaStreamPermissionSet(
       const GURL& request_origin,
       const MediaStreamDevicesController::MediaStreamTypePermissionMap&
           request_permissions);
 
-  // This method is called to pass the |form_to_save| on a successful password
-  // submission. It also updates the status of the save password content
-  // setting.
+  // Called when a password form is submitted. |form_to_save| is the submitted
+  // form. This form can save or blacklist the login credentials via
+  // PasswordAccepted() and PasswordFormBlacklisted respectively.

[Peter Kasting, 2013/09/11 21:49:39]

This comment is out of date; also see comments above.

[npentrel, 2013/09/12 10:08:44]

Done.

   void OnPasswordSubmitted(PasswordFormManager* form_to_save);
 
   // There methods are called to update the status about MIDI access.
   void OnMIDISysExAccessed(const GURL& reqesting_origin);
   void OnMIDISysExAccessBlocked(const GURL& requesting_origin);
 
   // Adds the given |SiteDataObserver|. The |observer| is notified when a
   // locale shared object, like for example a cookie, is accessed.
   void AddSiteDataObserver(SiteDataObserver* observer);
 
@@ skipping 71 matching lines @@
   GURL media_stream_access_origin_;
 
   // The PasswordFormManager managing the form we're asking the user about,
   // and should update as per the decision.
   scoped_ptr<PasswordFormManager> form_to_save_;
 
   DISALLOW_COPY_AND_ASSIGN(TabSpecificContentSettings);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_