Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.cc

Issue 23537029: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 2 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.cc
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.cc b/chrome/browser/content_settings/tab_specific_content_settings.cc
index 2b7550701d88ce0957004de8f3a042110b3da80d..41f987efa98011992d60229d2f6bc720992c3902 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.cc
+++ b/chrome/browser/content_settings/tab_specific_content_settings.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/content_settings/content_settings_details.h"
#include "chrome/browser/content_settings/content_settings_utils.h"
#include "chrome/browser/content_settings/host_content_settings_map.h"
-#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/render_messages.h"
@@ -99,15 +98,10 @@ TabSpecificContentSettings::~TabSpecificContentSettings() {
SiteDataObserver, observer_list_, ContentSettingsDestroyed());
}
-bool TabSpecificContentSettings::PasswordAccepted() {
+bool TabSpecificContentSettings::SetPasswordAction(
+ PasswordFormManager::PasswordAction password_action) {
DCHECK(form_to_save_.get());
- form_to_save_->SavePassword();
- return true;
-}
-
-bool TabSpecificContentSettings::PasswordFormBlacklisted() {
- DCHECK(form_to_save_.get());
- form_to_save_->BlacklistPassword();
+ form_to_save_->set_password_action(password_action);
Peter Kasting 2013/09/11 21:49:39 Nit: Seems like you can just make this function an
npentrel 2013/09/12 10:08:44 Done.
return true;
Peter Kasting 2013/09/11 21:49:39 Why does this return a bool at all? Shouldn't thi
npentrel 2013/09/12 10:08:44 Done.
}

Powered by Google App Engine
This is Rietveld 408576698