[SVGDom] Opacity optimization

[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005

Committed: https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc
Committed: https://skia.googlesource.com/skia/+/bef51c23c314180760b07f88fab50f6670f37f9b

[f(malita), 2016-09-20 15:27:10]

Description was changed from

==========
[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
==========

to

==========
[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005
==========

[f(malita), 2016-09-20 15:31:14]

Mike noticed we spend a lot of time in saveLayer/restore for e.g. car.svg. 
That's due to 'opacity' being used extensively for leaf nodes -- which lends
itself to this optimization.

In local testing, car.svg repaint time was reduced from ~98ms to ~15ms.

[f(malita), 2016-09-20 15:31:29]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:31:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-09-20 15:34:27]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:34:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-09-20 15:37:36]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:37:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:05:40]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2016-09-20 17:37:06]

lgtm

https://codereview.chromium.org/2353503005/diff/40001/experimental/svg/model/...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2353503005/diff/40001/experimental/svg/model/...
experimental/svg/model/SkSVGRenderContext.cpp:288: if ((flags & kLeaf) &&
(!hasFill || !hasStroke)) {
nit: you *could* write (hasFill ^ hasStroke) :)

[robertphillips, 2016-09-20 17:54:16]

lgtm

[f(malita), 2016-09-20 18:08:27]

https://codereview.chromium.org/2353503005/diff/40001/experimental/svg/model/...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2353503005/diff/40001/experimental/svg/model/...
experimental/svg/model/SkSVGRenderContext.cpp:288: if ((flags & kLeaf) &&
(!hasFill || !hasStroke)) {
On 2016/09/20 17:37:06, reed1 wrote:
> nit: you *could* write (hasFill ^ hasStroke) :)

Why not... done :)

[f(malita), 2016-09-20 18:08:30]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-09-20 18:08:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/2353503005/#ps60001
(title: "Win build fix + review")

[commit-bot: I haz the power, 2016-09-20 18:08:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:44:33]

Description was changed from

==========
[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005
==========

to

==========
[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005

Committed:
https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc
==========

[commit-bot: I haz the power, 2016-09-20 19:44:34]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc

[borenet, 2016-09-20 20:39:37]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2359603002/ by borenet@google.com.

The reason for reverting is: Failing assertion.

[f(malita), 2016-09-20 20:54:39]

On 2016/09/20 20:39:37, borenet wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2359603002/ by mailto:borenet@google.com.
> 
> The reason for reverting is: Failing assertion.

c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)"

Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running:
	msaa16 svg  cartman.svg
Likely culprit:
	msaa16 svg  cartman.svg

I don't see any opacity in cartman.svg, so I'd be surprised if the assert is
triggered by this CL.  Let's see what the bots say :)

[mtklein_C, 2016-09-20 22:43:59]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 22:45:59]

Description was changed from

==========
[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005

Committed:
https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc
==========

to

==========
[SVGDom] Opacity optimization

Apply opacity as fill/stroke paint alpha instead of saveLayer, when
possible.

R=robertphillips@google.com,stephana@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005

Committed:
https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc
Committed:
https://skia.googlesource.com/skia/+/bef51c23c314180760b07f88fab50f6670f37f9b
==========

[commit-bot: I haz the power, 2016-09-20 22:46:00]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/bef51c23c314180760b07f88fab50f6670f37f9b